Update gRPC-Java to 1.30.0 #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC-Java [1.30.0](https://github.com/grpc/grpc-java/releases/tag/v1.30.0) has been released We need a workaround for `ProtoReflectionService`. Because it does not implement `InternalNotifyOnServerBuild` anymore. See grpc/grpc-java#6967 line#2806 It is a temporary workaround until upstream handles grpc/grpc-java#7138. Motivations: - Upgrade gRPC to 1.30.0 from 1.29.0 - Add ProtoReflectionServiceInterceptor that injects dummy server to gRPC context. Result: You can run gRPC 1.30.0 with Armeria server. Fixes line#2806
trustin
reviewed
Jun 18, 2020
grpc/src/main/java/com/linecorp/armeria/server/grpc/ProtoReflectionServiceInterceptor.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Jun 18, 2020
grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcServiceBuilder.java
Outdated
Show resolved
Hide resolved
anuraaga
approved these changes
Jun 18, 2020
anuraaga
reviewed
Jun 18, 2020
| static final ProtoReflectionServiceInterceptor INSTANCE = new ProtoReflectionServiceInterceptor(); | ||
|
|
||
| @Nullable | ||
| private static Server dummyServer; |
There was a problem hiding this comment.
Ah - is this supposed to be static? If so this interceptor can be static too, and yeah back to the idea we can call ProtoReflectionServiceInterceptor.addServerConfig() where we used to call notifyOnBuild
There was a problem hiding this comment.
Replied at #2814 (comment)
trustin
approved these changes
Jun 18, 2020
anuraaga
approved these changes
Jun 18, 2020
trustin
reviewed
Jun 18, 2020
Ahh, I didn't think of that case. Thanks! |
trustin
approved these changes
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
============================================
- Coverage 72.78% 72.68% -0.10%
- Complexity 11945 11947 +2
============================================
Files 1049 1048 -1
Lines 46554 46626 +72
Branches 5810 5829 +19
============================================
+ Hits 33883 33890 +7
- Misses 9705 9744 +39
- Partials 2966 2992 +26 Continue to review full report at Codecov.
|
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: gRPC-Java [1.30.0](https://github.com/grpc/grpc-java/releases/tag/v1.30.0) has been released We need a workaround for `ProtoReflectionService`. Because it does not implement `InternalNotifyOnServerBuild` anymore. See grpc/grpc-java#6967 line#2806 It is a temporary workaround until upstream handles grpc/grpc-java#7138. Modifications: - Upgrade gRPC to 1.30.0 from 1.29.0 - Add ProtoReflectionServiceInterceptor that injects dummy server to gRPC context. Result: You can run gRPC 1.30.0 with Armeria server. Fixes line#2806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC-Java 1.30.0 has been released
We need a workaround for
ProtoReflectionService. Because it does not implementInternalNotifyOnServerBuildanymore.See grpc/grpc-java#6967 #2806
It is a temporary workaround until upstream handles grpc/grpc-java#7138.
Modifications:
gRPC context.
Result:
You can run gRPC 1.30.0 with Armeria server.
Fixes #2806