Provide a way to log successful and failed requests #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
TBU
Modifications:
TBU
Result:
Logging configuration example:
```json
{
"targetGroups": [ "API", "HEALTH" ],
"loggerName": "centraldogma.test",
"requestLogLevel": "DEBUG",
"successfulResponseLevel": "DEBUG",
"failureResponseLevel": "ERROR",
"successSamplingRate": 0.4,
"failureSamplingRate": 0.6
}
```
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
============================================
+ Coverage 70.31% 70.40% +0.08%
- Complexity 3418 3444 +26
============================================
Files 349 351 +2
Lines 13470 13565 +95
Branches 1454 1466 +12
============================================
+ Hits 9472 9550 +78
- Misses 3139 3153 +14
- Partials 859 862 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jrhee17
reviewed
Sep 8, 2022
| logHealthCheck = true; | ||
| logMetrics = true; | ||
| } else { | ||
| for (RequestLogGroup logGroup : requestLogGroups) { |
There was a problem hiding this comment.
Question: Is it possible that users may want to configure different logging parameters for different paths?
e.g.
- METRIC: debug
- API: info
- ...
There was a problem hiding this comment.
Oh... It is so nice! 👍
There was a problem hiding this comment.
We can implement it by adding different LoggingServices.
minwoox
reviewed
Oct 7, 2022
|
|
||
| private final Set<RequestLogGroup> targetGroups; | ||
|
|
||
| private final LogLevel requestLogLevel; |
There was a problem hiding this comment.
Shouldn't we allow to set different settings per RequestLogGroup?
| logHealthCheck = true; | ||
| logMetrics = true; | ||
| } else { | ||
| for (RequestLogGroup logGroup : requestLogGroups) { |
There was a problem hiding this comment.
How about also supporting the specified path? e.g. /api/v1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To diagnose an exception error on the client-side, request logs are important to check request parameters, response duration and application errors.
Modifications:
RequestLogConfigwhich can limit the sampling rate, adjust target groups, and set the logging levels.TransientServiceOption.WITH_SERVICE_LOGGINGis specified toHealthCheckServiceorPrometheusExpositionServiceif
METRICSorHEALTHgroup is defined inRequestLogConfigResult:
{ "targetGroups": [ "API", "HEALTH" ], "loggerName": "centraldogma.test", "requestLogLevel": "DEBUG", "successfulResponseLevel": "DEBUG", "failureResponseLevel": "ERROR", "successSamplingRate": 0.4, "failureSamplingRate": 0.6 }LoggingServicein Central Dogma server #718