Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github workflow with JDK21 #927

Merged
merged 4 commits into from
May 10, 2024
Merged

Update Github workflow with JDK21 #927

merged 4 commits into from
May 10, 2024

Conversation

thachlp
Copy link
Member

@thachlp thachlp commented Mar 9, 2024 •
edited

Motivation
Since Java 21 is an LTS version released on September 19, 2023. We should update the CI Github build.

Result
Close #911

@codecov Codecov
Copy link

codecov bot commented Mar 9, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (54205bf) to head (1623214).
Report is 20 commits behind head on main.

❗ Current head 1623214 differs from pull request most recent head 9d72144. Consider uploading reports for the commit 9d72144 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #927      +/-   ##
============================================
- Coverage     66.78%   66.75%   -0.03%     
+ Complexity     3513     3511       -2     
============================================
  Files           370      370              
  Lines         14476    14476              
  Branches       1553     1553              
============================================
- Hits           9668     9664       -4     
- Misses         3929     3934       +5     
+ Partials        879      878       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thachlp thachlp changed the title update-github-workflow-jdk21 Update Github workflow with JDK21 Mar 9, 2024
ikhoon
ikhoon reviewed Mar 15, 2024
View reviewed changes
.github/workflows/actions_build.yml Outdated
@@ -28,7 +28,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-12, windows-latest]
java: [17]
java: [17, 21]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we upgrade BUILD_JDK_VERSION to 21 as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I updated

.github/workflows/actions_build.yml Outdated
Comment on lines 43 to 46
- java: 19
os: ubuntu-latest
- java: 21
os: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use non-LTS for the latest version. Let's remove Java 19 version.

Suggested change
- java: 19
os: ubuntu-latest
- java: 21
os: ubuntu-latest
- java: 21
os: ubuntu-latest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

jrhee17
jrhee17 reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also modify to release from 21?

centraldogma/build.gradle

Line 141 in 2994712

// Require to use JDK 17 when releasing.

.github/workflows/actions_build.yml Outdated Show resolved Hide resolved
@thachlp @jrhee17
Update .github/workflows/actions_build.yml
1623214 
Co-authored-by: jrhee17 <guins_j@guins.org>
@minwoox
Copy link
Member

minwoox commented May 10, 2024

Please address this comment. 🙇
#927 (review)
Does anyone know why we didn't use JDK 19 before?

@ikhoon
Copy link
Contributor

ikhoon commented May 10, 2024

Maybe it wasn't a LTS version or we are lazy? 😅

@thachlp
Copy link
Member Author

thachlp commented May 10, 2024

Can we also modify to release from 21?

centraldogma/build.gradle

Line 141 in 2994712

// Require to use JDK 17 when releasing.

Hi @jrhee17, updated 🙇

@thachlp
Copy link
Member Author

thachlp commented May 10, 2024

Please address this comment. 🙇 #927 (review) Does anyone know why we didn't use JDK 19 before?

Thanks, @minwoox, I missed that comment.

minwoox
minwoox approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @thachlp 😆

jrhee17
jrhee17 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox minwoox merged commit adb71ab into line:main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikhoon ikhoon ikhoon approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@minwoox minwoox minwoox approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Github Workflow CI build target
4 participants
@thachlp @minwoox @ikhoon @jrhee17