Add a metric for tracking the number of pushes #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It is difficult to check how many commits have been pushed to a specific repository without looking at log files. This PR is the orignal commit of line#943 that tracks the number of pushes instead of adding `project` and `repo` tags to all `api` metrics. line#943 has been reverted because it increased in CPU and memory usage. Modifications: - Add a `Counter` that is increased when a commit is pushed to a repository. - `project` and `repository` are added as tags. Result: You can monitor the number of pushes to a repository using the `commits.push` metric.
jrhee17
reviewed
May 2, 2024
...er/src/test/java/com/linecorp/centraldogma/server/internal/api/converter/PushMetricTest.java
Show resolved
Hide resolved
Otherwise, we may add a filter to tag repositories selectively. The filter could be used to exclude less interesting repositories generated mechanically by a plugin or bot. interface RepositoryMetricFilter {
boolean shouldTagRepository(String projectName, String repoName);
}
new CentralDogmaBuilder()
.repositoryMetricFilter((project, repo) -> {
if (project.equals(registryProject) {
return false;
} else {
return true;
}
}); |
minwoox
reviewed
May 21, 2024
| @@ -190,6 +194,10 @@ public CompletableFuture<PushResultDto> push( | |||
| CommitMessageDto commitMessage, | |||
| @RequestConverter(ChangesRequestConverter.class) Iterable<Change<?>> changes) { | |||
| checkPush(repository.name(), changes); | |||
| meterRegistry.counter("commits.push", | |||
There was a problem hiding this comment.
Note: Didn't add this counter to ThriftService because it's going to be deprecated.
|
@ikhoon 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It isn't easy to check how many commits have been pushed to a specific repository without looking at log files.
This PR is the orignal commit of #943 that tracks the number of pushes instead of adding
projectandrepotags to allapimetrics. #943 has been reverted because it increased in CPU and memory usage.Modifications:
Counterthat is increased when a commit is pushed to a repository.projectandrepositoryare added as tags.Result:
You can monitor the number of pushes to a repository using the
commits.pushmetric.