Add document for subpartition runtime #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocadaruma
reviewed
Mar 27, 2024
| --param=decaton.subpartition.runtime=THREAD_POOL | ||
| ---- | ||
|
|
||
| image::runtime-benchmark-conc-peak.png[] |
There was a problem hiding this comment.
Though I understand that the focus of this appendix is about throughput-cap, I guess this graph might make confusing impression because 30000 with 20ms (4ms * 5) latency is still higher than vthread throughput shown in above graph. (So people may think "Got it, threadpool-runtime throughput will be capped by 30000 in 20ms-latency scenario. But vthread-runtime can't achieve 30000 in the first place....")
Isn't it better to show throughput cap with more high simulated latency like 100ms?
There was a problem hiding this comment.
Hm, changed my mind.
Maybe I'm worrying too much. LGTM
ocadaruma
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also piggy-back benchmark addition for the virtual thread runtime.