Use TopicPartition.topic for metrics #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kawamuray
requested changes
May 16, 2024
| @@ -59,7 +59,7 @@ protected AbstractSubPartitions(PartitionScope scope, Processors<?> processors) | |||
| rateLimiter = new DynamicRateLimiter(rateProperty(scope)); | |||
| Metrics metrics = Metrics.withTags( | |||
| "subscription", scope.subscriptionId(), | |||
| "topic", scope.topic(), | |||
| "topic", scope.topicPartition().topic(), | |||
There was a problem hiding this comment.
in addition to these changes I wanna make the following changes to ensure we won't repeat the same mistake in future. Are you happy to follow these up in this PR? Otherwise I'll cover that after merging this PR.
- Let's use variable to assign
scope.topicPartition()return and use it instead to avoid unnecessary object allocation. - Rename
SubscriptionScope.topicto beSubscriptionScope.originTopicto distinguish it w/ PartitionScope.topicPartition
There was a problem hiding this comment.
Thank you for your review. I see, I'll update them as well.
|
This has been released as 8.0.1. Thanks for your contribution :) https://github.com/line/decaton/releases/tag/v8.0.1 |
|
OK, thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scope.topic()after Add virtual threads support #224.scope.topicPartition().topic()to use the retry topic name for metrics when handling the retry topic.