feat: ignore URL params on matching #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenorok
force-pushed
the
ignore-url-params
branch
from
56fc6d1
to
58218c1
Compare
tenorok
commented
Jun 14, 2022
| const channel = addons.getChannel(); | ||
| faker.makeInitialRequestMap(parameters); | ||
| faker.makeInitialRequestMap(options.concat(parameters)); |
There was a problem hiding this comment.
At the same time I supported story options.
tenorok
force-pushed
the
ignore-url-params
branch
from
370076d
to
15b0494
Compare
tenorok
commented
Jun 15, 2022
| @@ -1,3 +1,21 @@ | |||
| declare const withMock: (storyFn: any) => any; | |||
| declare const withMock: (options: RequestInfo[]) => any; | |||
There was a problem hiding this comment.
And also by the way I wrote base types for TypeScript, if you don't mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78