Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change the unnecessarily mocking tone of the React docs #1905

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

andrii-bodnar
Copy link
Contributor

Description

#1904

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 7:37am

Copy link

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we should not only remove the mocking tone but explicitly admit / warn that Trans changes the standard JSX behavior.

It's true it doesn't make sense to write <Trans>{isOpen && <Modal />}</Trans> but it makes sense to write more complicated JSX as noted in #1904

@andrii-bodnar
Copy link
Contributor Author

@vonovak do you have any ideas on how to note this compactly without giving another example for this specific case?

Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, considering #1906 we can merge this as-is

@andrii-bodnar andrii-bodnar merged commit 69c1c23 into main Apr 8, 2024
15 checks passed
@andrii-bodnar andrii-bodnar deleted the docs/more-formal branch April 8, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants