fix(core): pound symbol being replaced outside plural and selectordinal

[dan-dr]

Description

Fixes #1927

Added appropriate test

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Examples update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2024 0:53am

[dan-dr]

not sure regarding the naming of replaceOctothorpe rather than isPluralOrSelectOrdinal or something like that.

Another possibility is doing the #->OCTOTHORPE_PH replacement before sending the value to formatMessage rather than the if block https://github.com/lingui/js-lingui/pull/1928/files#diff-250f1fdd34ada7b2793f80e74f6f6b2a60837d0a55b4ae534c32ace02a988000R105

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.86 KB (0%)
./packages/detect-locale/dist/index.mjs	723 B (0%)
./packages/react/dist/index.mjs	1.67 KB (0%)
./packages/remote-loader/dist/index.mjs	7.26 KB (0%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.01%. Comparing base (d6b9698) to head (2fba52e).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
- Coverage   76.65%   76.01%   -0.64%     
==========================================
  Files          81       85       +4     
  Lines        2090     2110      +20     
  Branches      533      539       +6     
==========================================
+ Hits         1602     1604       +2     
- Misses        375      393      +18     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrii-bodnar]

@dan-dr thank you!