fix #271 - give feedback for unrecognized commands #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dephiros
changed the title
dephiros
force-pushed
the
fix/271-error-for-unknown-command
branch
from
d524c33
to
78b7755
Compare
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 91.66% 91.82% +0.15%
==========================================
Files 42 42
Lines 1104 1113 +9
==========================================
+ Hits 1012 1022 +10
+ Misses 92 91 -1
Continue to review full report at Codecov.
|
dephiros
force-pushed
the
fix/271-error-for-unknown-command
branch
from
78b7755
to
f2153d7
Compare
danielkcz
reviewed
Sep 1, 2018
dephiros
force-pushed
the
fix/271-error-for-unknown-command
branch
from
f2153d7
to
3fb55f1
Compare
|
Realized that I forgot to push up the test file. Will push it up tonight |
|
@dephiros Yeah, don't worry about it. I honestly don't know why the test fails, but I rerun the test suit and everything is fine. I'm gonna merge it in the morning. Great job, thank you very much! ⚡️ ⚡️ ⚡️ |
tricoder42
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Alright, I made few changes, but otherwise this PR is good. Thank you for working on this! Really helpful.
- I moved all
console.loginside utility function, because the output strings usechalkanyway, so it's used only in console anyway. - Only one command is passed to utility function. I believe it's enough to show the user there's something wrong.
- finally, I renamed the function to
helpMisspelledCommandbecause it basically shows a help to user. Similar tohelpfrom commander.
tricoder42
changed the title
Photonios
pushed a commit
to SectorLabs/js-lingui
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #271