Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setting to install CLI package as bin #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StefanoPastore
Copy link
Collaborator

@StefanoPastore StefanoPastore commented Nov 13, 2022

Description

Add missing bin setting in package json in order to let package manager know that it must be added to the bin folder when it is installed.
See documentation here.

Copy link
Contributor

@LucaColonnello LucaColonnello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the name, but good otherwise!! Does it work? I was wondering if the ts config compiles to esmodules or commonjs, as I don't know how you would load an esm as a bin 🤔

@@ -11,6 +11,9 @@
"node": "16"
},
"main": "lib/index.js",
"bin": {
"@link-to-code/cli": "./bin/cli"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give this a simpler name, like simply link-to-code? This is what is then used by people in terminals, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants