Tool to reconstruct prod resources based on Micheal's clique layout (Not to be checked in) #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private IdealState buildIdealState(String resourceName, Map<String, List<String>> preferenceLists) { | ||
| IdealState idealState = new IdealState(resourceName); | ||
| idealState.setStateModelDefRef(ClusterMapConfig.DEFAULT_STATE_MODEL_DEF); | ||
| for (Map.Entry<String, List<String>> entry : preferenceLists.entrySet()) { |
There was a problem hiding this comment.
let's explicitly set rebalance mode to semi auto, and the ideal state mode to auto, for now
| for (String host : hosts) { | ||
| String instanceName = ClusterMapUtils.getInstanceName(host, port); | ||
| if (currentStates.containsKey(instanceName)) { | ||
| List<String> partitions = currentStates.get(instanceName); |
There was a problem hiding this comment.
let remove the instance name form the currentStates map and verify that the currentStates map is empty after the for loop to make sure the current states map has as many hosts as the resourceToHosts map.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2579 +/- ##
============================================
- Coverage 72.68% 72.05% -0.63%
- Complexity 11304 11407 +103
============================================
Files 801 806 +5
Lines 64163 65296 +1133
Branches 7827 7985 +158
============================================
+ Hits 46635 47050 +415
- Misses 14973 15660 +687
- Partials 2555 2586 +31
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.