Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maxKeys for list request #2779

Merged

Conversation

SophieGuo410
Copy link
Contributor

@SophieGuo410 SophieGuo410 commented May 7, 2024

This pr support maxKeys for list request so user can provide maximum number of entities they want to return for list request.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.23%. Comparing base (52ba813) to head (1653d3a).
Report is 8 commits behind head on master.

Files Patch % Lines
...b/ambry/tools/perf/NamedBlobMysqlDatabasePerf.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2779      +/-   ##
============================================
+ Coverage     64.24%   70.23%   +5.99%     
- Complexity    10398    11672    +1274     
============================================
  Files           840      840              
  Lines         71755    71880     +125     
  Branches       8611     8637      +26     
============================================
+ Hits          46099    50487    +4388     
+ Misses        23004    18755    -4249     
+ Partials       2652     2638      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SophieGuo410 SophieGuo410 force-pushed the Branch_support_list_upgrade branch 2 times, most recently from d9c5c46 to c5f19a1 Compare May 7, 2024 22:26
@SophieGuo410 SophieGuo410 marked this pull request as ready for review May 7, 2024 23:11
@SophieGuo410 SophieGuo410 force-pushed the Branch_support_list_upgrade branch 2 times, most recently from bbb19f1 to edb6a51 Compare May 9, 2024 22:43
Copy link
Collaborator

@JingQianCloud JingQianCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SophieGuo410 SophieGuo410 merged commit 18e281e into linkedin:master May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants