feat(goavro) Adding method to return typename associated with Codec #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Overview:** In order to identify the kafka topic name from a stream of topics, we need to identify the underlying type associated with the provided Codec data The `Codec.typeName` field already contains this information but is currently package private and cannot be used outside of the package This PR adds the `TypeName` method to `Codec` to expose the underlying type name outside the goavro package scope This also adds the `ShortName` method to `Name` to expose the short name (i.e. record name excluding classpath) as a public method
jwon
approved these changes
May 2, 2024
added 2 commits
May 2, 2024 12:05
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/linkedin/goavro/v2](https://togithub.com/linkedin/goavro) | `v2.12.0` -> `v2.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>linkedin/goavro (github.com/linkedin/goavro/v2)</summary> ### [`v2.13.0`](https://togithub.com/linkedin/goavro/releases/tag/v2.13.0): Release to expose underlying TypeName in Codec [Compare Source](https://togithub.com/linkedin/goavro/compare/v2.12.0...v2.13.0) This release updates the `Codec` type to surface the underlying typeName via a public API - Adds the `TypeName` method to `Codec` to expose the underlying type name outside the goavro package scope - Adds the `ShortName` method to `Name` to expose the short name (i.e. record name excluding classpath) as a public method Ref. PR: [linkedin/goavro#285 by [@​mittal-aashay](https://togithub.com/mittal-aashay) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…y#32911) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/linkedin/goavro/v2](https://togithub.com/linkedin/goavro) | `v2.12.0` -> `v2.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>linkedin/goavro (github.com/linkedin/goavro/v2)</summary> ### [`v2.13.0`](https://togithub.com/linkedin/goavro/releases/tag/v2.13.0): Release to expose underlying TypeName in Codec [Compare Source](https://togithub.com/linkedin/goavro/compare/v2.12.0...v2.13.0) This release updates the `Codec` type to surface the underlying typeName via a public API - Adds the `TypeName` method to `Codec` to expose the underlying type name outside the goavro package scope - Adds the `ShortName` method to `Name` to expose the short name (i.e. record name excluding classpath) as a public method Ref. PR: [linkedin/goavro#285 by [@&open-telemetry#8203;mittal-aashay](https://togithub.com/mittal-aashay) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
](https://renovatebot.com){kind=link}
…y#32911) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/linkedin/goavro/v2](https://togithub.com/linkedin/goavro) | `v2.12.0` -> `v2.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>linkedin/goavro (github.com/linkedin/goavro/v2)</summary> ### [`v2.13.0`](https://togithub.com/linkedin/goavro/releases/tag/v2.13.0): Release to expose underlying TypeName in Codec [Compare Source](https://togithub.com/linkedin/goavro/compare/v2.12.0...v2.13.0) This release updates the `Codec` type to surface the underlying typeName via a public API - Adds the `TypeName` method to `Codec` to expose the underlying type name outside the goavro package scope - Adds the `ShortName` method to `Name` to expose the short name (i.e. record name excluding classpath) as a public method Ref. PR: [linkedin/goavro#285 by [@&open-telemetry#8203;mittal-aashay](https://togithub.com/mittal-aashay) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlYm90Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Overview:
In order to identify the kafka topic name from a stream of topics, we need to identify the underlying type associated with the provided Codec data
The
Codec.typeNamefield already contains this information but is currently package private and cannot be used outside of the packageThis PR adds the
TypeNamemethod toCodecto expose the underlying type name outside the goavro package scopeThis also adds the
ShortNamemethod toNameto expose the short name (i.e. record name excluding classpath) as a public methodTesting Done
Added unit tests