Support ldap login with start tls #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgp
requested changes
Sep 14, 2017
| @@ -10,16 +10,21 @@ class Authenticator: | |||
| def __init__(self, config): | |||
| root = os.path.abspath('./') | |||
| self.ldap_url = config['auth']['ldap_url'] | |||
| self.cert_path = os.path.join(root, config['auth']['ldap_cert_path']) | |||
| self.start_tls = config['auth']['start_tls'] | |||
There was a problem hiding this comment.
can you update the sample config to add the new usage of this?
| self.user_suffix = config['auth']['ldap_user_suffix'] | ||
| self.authenticate = self.ldap_auth | ||
| if config.get('debug'): | ||
| self.authenticate = self.debug_auth | ||
|
|
||
| def ldap_auth(self, username, password): | ||
| ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, self.cert_path) | ||
| if not self.start_tls: |
There was a problem hiding this comment.
is start tls mutually exclusive with passing a cacert file?
dwang159
requested changes
Sep 14, 2017
| @@ -10,16 +10,21 @@ class Authenticator: | |||
| def __init__(self, config): | |||
| root = os.path.abspath('./') | |||
| self.ldap_url = config['auth']['ldap_url'] | |||
| self.cert_path = os.path.join(root, config['auth']['ldap_cert_path']) | |||
| self.start_tls = config['auth']['start_tls'] | |||
There was a problem hiding this comment.
Switch to config['auth'].get('start_tls') to maintain existing behavior without need for config change
|
I can pick this up and address the remaining issues. I agree, it should use I also would like an option to ignore server certs / name. I have a prototype code to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.