[controller] Do not delete true backup version during Repush #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynameborat
reviewed
Apr 18, 2024
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/ReadOnlyStore.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/VersionImpl.java
Outdated
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
...oller/src/test/java/com/linkedin/venice/controller/TestStoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
...oller/src/test/java/com/linkedin/venice/controller/TestStoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
gaojieliu
requested changes
Apr 24, 2024
internal/venice-common/src/main/java/com/linkedin/venice/meta/Version.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/ReadOnlyStore.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/main/java/com/linkedin/venice/meta/VersionImpl.java
Outdated
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
services/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceHelixAdmin.java
Outdated
Show resolved
Hide resolved
...oller/src/test/java/com/linkedin/venice/controller/TestStoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
added 10 commits
May 15, 2024 14:25
gaojieliu
reviewed
May 15, 2024
...ces/venice-controller/src/main/java/com/linkedin/venice/controller/server/CreateVersion.java
Outdated
Show resolved
Hide resolved
...ces/venice-controller/src/main/java/com/linkedin/venice/pushmonitor/AbstractPushMonitor.java
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Show resolved
Hide resolved
...ontroller/src/main/java/com/linkedin/venice/controller/StoreBackupVersionCleanupService.java
Outdated
Show resolved
Hide resolved
|
@smaji, after my rebase integrated this PR, I found three naked gets introduced by this change. I fixed them so that the code compiles, but we may wish to handle them differently than what I did. Can you please take a look at this commit and LMK if you have any concerns with the way I handled these naked gets? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not delete true backup version during Repush
During repush Venice deletes the actual backup version instead of current version.
For example some store has versions: v9, v10. When a repush starts it creates v11 and it deletes v9 assuming it is a backup version, where as repush actually copies data from v10 to v11.
Now later if use wants to rollback to backup version they can only rollback to v10 which is exactly same as v11 as v9 was deleted.
This PR fixes that. It relies on
StoreBackupVersionCleanupServiceto delete the backup version v10 asynchronously. Currently it checkscontroller.backup.version.metadata.fetch.cleanup.enabledto do a safer delete of previous current version which validates there are no reads to v10 version.How was this PR tested?
CI
Does this PR introduce any user-facing changes?
The change in backup version definition for repush, the backup version is the current version before push instead of version before that.