[fast-client][server] Throw 403 for metadata request that does not have storage read quota enabled #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamxchen
reviewed
May 6, 2024
...s/venice-server/src/main/java/com/linkedin/venice/listener/ServerReadMetadataRepository.java
Outdated
Show resolved
Hide resolved
adamxchen
previously approved these changes
May 6, 2024
This is done manually for now but later it can and will be automated/self serve. |
xunyin8
force-pushed
the
BlockNonSNEnabledFC
branch
2 times, most recently
from
4d5ced4
to
3244fe2
Compare
…ve storage read quota enabled 1. The idea is to block new fast-client traffic that do not have storage node read quota enabled. New client version will fail fast and have a clear error message to direct the user on what's missing. Old client versions will keep failing the metadata request and the user will also see the error message once dig deeper into the error trace.
xunyin8
force-pushed
the
BlockNonSNEnabledFC
branch
2 times, most recently
from
e6b1a48
to
699081e
Compare
xunyin8
force-pushed
the
BlockNonSNEnabledFC
branch
from
699081e
to
21ff7d9
Compare
This was referenced May 16, 2024
mynameborat
added a commit
that referenced
this pull request
May 21, 2024
- Fix tests failures due to [fast-client][server] Throw 403 for metadata request that does not have storage read quota enabled #975 - Extracting the test fixes from [internal][client] Support GRPC port discovery for non-local environment #987 - Reset storage node read quota enabled flag prior to each test in FastClientIndividualFeatureConfigurationTest Co-authored-by: Bharath Kumarasubramanian <bkumarasubramanian@linkedin.com>
mynameborat
added a commit
that referenced
this pull request
May 23, 2024
…ent (#987) - [Functional] Introduce logic to use fallback Grpc port for netty server address -> Grpc server mapping - [Refactor] Modularize request handling and remove boiler plate in GrpcTransportClient - [Bug fix] Fix integration tests that was failing due to [fast-client][server] Throw 403 for metadata request that does not have storage read quota enabled #975 - [Clean up] Remove some validations, added few invariants check and reorganize some depending on the mode (local vs integration/production) - [Clean up] Rename fields to remove type information - [Test] Add unit tests for GrpcTransportClient class Co-authored-by: Bharath Kumarasubramanian <bkumaras@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fast-client][server] Throw 403 for metadata request that does not have storage read quota enabled
How was this PR tested?
Unit test and integration test
Does this PR introduce any user-facing changes?