[WIP] Utilize temp cache and skip syncOffset during CATCHING_UP phase #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacAttack
reviewed
May 8, 2024
| // To improve bootstrapping performance, we'll put raw data in a temp cache (hashmap) and will | ||
| // process save to underlying storage on CATCHING_UP completion. Besides, we'll also skip RocksDB syncOffset. | ||
| if (bootstrapState.bootstrapState == PollState.CATCHING_UP) { | ||
| bootstrapState |
There was a problem hiding this comment.
idk about this. It seems like the cache could grow to a pretty large size. We should probably put a size safety check in here to control flushing to disk.
zx0401
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[changelog][BootstrappingVeniceChangelogConsumer] Utilize temp cache and skip syncOffset during CATCHING_UP phase to improve bootstrapping performance
Summary, imperative, start upper case, don't end with a period
How was this PR tested?
Does this PR introduce any user-facing changes?