[DO NOT USE] Add data model and initial implementation for backup #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testOutstandingHandshakeLimit is flaky, I tried to fix it in this commit. - I added extra comments and did some restructuring in the code. - Avoiding to start unnecessary ZooKeeper servers for tests don't require it - Decreasing the number of client connections the test tries to initiate - Increasing the timeout to make sure the connections get established - Filtering the 'SyncConnected' events in the client watcher to make sure the given connection is really established before counting it I think the last two points above should fix the flakiness. I tried to run the test in docker, and before the fix it failed for me once in every 4-5 execution. After applying these changes I re-executed it 100 times without failure. If these fixes are not enough, then we can introduce some only-visible-by-test method to add sleep in the SSLHandshake process in the production code to force to have handshakes in parallel. However, it would be nice to avoid that. Let's hope that these fixes will be enough. Author: Mate Szalay-Beko <szalay.beko.mate@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@cloudera.com> Closes apache#1184 from symat/ZOOKEEPER-3651 (cherry picked from commit 20daae7) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Author: sujithsimon22 <sujith.abraham.simon@huawei.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>,Mohammad Arshad <arshad@apache.org> Closes apache#1185 from sujithsimon22/master (cherry picked from commit 7c9a1e4) Signed-off-by: Mohammad Arshad <arshad@apache.org>
I have removed hadoop logo from header.html present in zookeeper-documentation and also the image hadoop-logo.jpg from images. Please do let me know if I have missed anything. Author: ravowlga123 <ravowlga@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Justin Ling Mao <maoling199210191@sina.com> Closes apache#1179 from ravowlga123/ZOOKEEPER-3648 (cherry picked from commit 56f508f) Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
snapshot.trust.empty can be used in both zoo.cfg file (with name snapshot.trust.empty), and as a system property (with name zookeeper.snapshot.trust.empty). Author: Michael Han <lhan@twitter.com> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1178 from hanm/ZOOKEEPER-3056 (cherry picked from commit 04e91c3) Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
This is the 2nd part of data consistency based on digest, it checks the DataTree digest on every txn during broadcast time. Author: Fangmin Lyu <fangmin@apache.org> Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Andor Molnar <andor@apache.org>, Michael Han <hanm@apache.org> Closes apache#1059 from lvfangmin/ZOOKEEPER-3512 (cherry picked from commit 2805e89) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
- add LICENSE files for Snappy and Metrics core - update Copyright year - copy airlift reference to the NOTICE file of the binary packages - copy the Java 8 disclaimer from branch-3.5 Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Andor Molnar <anmolnar@apache.org> Closes apache#1196 from eolivelli/fix/license-stuff
Batch mode never was implemented in `cli_mt`. This patch seems to work, but: 1. There may be a cleaner way of waiting for the completion; 2. ~~`nanosleep` is POSIX; the Windows path should probably use `Sleep`~~ (DONE). symat: Comments welcome. Author: Damien Diederen <dd@crosstwine.com> Reviewers: andor@apache.org Closes apache#1173 from ztzg/ZOOKEEPER-3640-implement-batch-mode-in-cli-mt (cherry picked from commit d7bc7b1) Signed-off-by: Andor Molnar <andor@apache.org>
Author: Colm O hEigeartaigh <coheigea@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1165 from coheigea/ZOOKEEPER-3638 (cherry picked from commit 178e8de) Signed-off-by: Andor Molnar <andor@apache.org>
As per [ZOOKEEPER-2083](https://jira.apache.org/jira/browse/ZOOKEEPER-2083) we need to remove class AuthFastLeaderElection.java so I made changes in Quorumpeer.java by removing two cases 1 and 2 present in createElectionAlgorithm as QuorumPeerconfig.electioalg is always 3. Please do let me know if anything additional needs to be done. Author: ravowlga123 <ravowlga@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Andor Molnar <anmolnar@apache.org>, Patrick Hunt <phunt@apache.org> Closes apache#1171 from ravowlga123/ZOOKEEPER-2083 (cherry picked from commit 590e3cb) Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
As per the ticket [ZOOKEEEPER-3649](https://issues.apache.org/jira/browse/ZOOKEEPER-3649) we need to add line break ls -s command. To achieve the desired behavior I have added new line character in option.add of LsCommand.printChildren(). Please do let me know if made changes gives us the desired behavior or if anything else needs to be changed. Author: ravowlga123 <ravowlga@gmail.com> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1183 from ravowlga123/ZOOKEEPER-3649 and squashes the following commits: f2e1997 [ravowlga123] ZOOKEEPER-3649 Removed additional new line from printChildren b36d636 [ravowlga123] ZOOKEEPER-3649 Add a line break in ls -s CLI (cherry picked from commit 570285a) Signed-off-by: Andor Molnar <andor@apache.org>
Removed Ls2Command.java, DeleteAllCommand.printdeprecatedwarning(), statements creating new objects for ls2 and rmr in ZookeeperMain.java. Updated zookeeperCLI.md and ZookeeperTest.java. Please do let me know if any additional changes are needed Author: ravowlga123 <ravowlga@gmail.com> Reviewers: andor@apache.org Closes apache#1175 from ravowlga123/ZOOKEEPER-3411 (cherry picked from commit 27b92ca) Signed-off-by: Andor Molnar <andor@apache.org>
….6.0 - use the same configuration as in Apache Parent Pom to generate the source tarball - drop the custom made configuration for the source tarball Author: Enrico Olivelli <enrico.olivelli@diennea.com> Reviewers: andor@apache.org Closes apache#1226 from eolivelli/fix/ZOOKEEPER-3695-source-tarball and squashes the following commits: 781d95e [Enrico Olivelli] Fix typo 21eac30 [Enrico Olivelli] Fix formatting and add comment 7eca978 [Enrico Olivelli] ZOOKEEPER-3695 Source release tarball does not match repository in 3.6.0 - use the same configuration as in Apache Parent Pom to generate the source tarball - drop the custom made configuration for the source tarball (cherry picked from commit 9053f7c) Signed-off-by: Andor Molnar <andor@apache.org>
…4j 1.2 deserialization of untrusted data in SocketServer Suppress error for CVE-2019-17571 as it does not affect us. We are not running the log4j server. Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: phunt@apache.org Closes apache#1209 from eolivelli/fix/ZOOKEEPER-3677-owasp-log4j Change-Id: I0ef24a7b142cd32ccf4f5c18f9e0c0132a413d6c (cherry picked from commit 3bd6b19) Signed-off-by: Patrick Hunt <phunt@apache.org>
…ception Author: sujithsimon22 <sujith.abraham.simon@huawei.com> Reviewers: Mohammad Arshad <arshad@apache.org> Closes apache#1222 from sujithsimon22/3667 (cherry picked from commit 49ad75b) Signed-off-by: Mohammad Arshad <arshad@apache.org>
…when user accidentally includes spaces at the end of the value Author: sujithsimon22 <sujith.abraham.simon@huawei.com> Reviewers: Allan Lyu <fangmin@apache.org>,Justin Mao Ling <maoling199210191@sina.com>,Mohammad Arshad <arshad@apache.org> Closes apache#1190 from sujithsimon22/3613 (cherry picked from commit dcef1a6) Signed-off-by: Mohammad Arshad <arshad@apache.org>
Author: David Mollitor <dmollitor@apache.org> Reviewers: fangmin@apache.org, andor@apache.org Closes apache#1197 from belugabehr/ZOOKEEPER-3669 (cherry picked from commit 517ecde) Signed-off-by: Andor Molnar <andor@apache.org>
We had some issues about configuring Kerberos authentication with SSL, so I created some unit tests to verify that these features work together. The problem was originally reported on 3.5.5. There was some conflicts to backport the tests to 3.5, I will prepare a separate PR on that branch. Author: Mate Szalay-Beko <szalay.beko.mate@gmail.com> Author: Mate Szalay-Beko <mszalay@cloudera.com> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1204 from symat/ZOOKEEPER-3482-master and squashes the following commits: 53194f5 [Mate Szalay-Beko] ZOOKEEPER-3482: update SASL related documentation 576ac0b [Mate Szalay-Beko] Merge remote-tracking branch 'apache/master' into ZOOKEEPER-3482-master 28da105 [Mate Szalay-Beko] ZOOKEEPER-3482: reload SASL and Kerberos configs before executing the tests 396c73e [Mate Szalay-Beko] ZOOKEEPER-3482: add unit tests for client SASL authentication over SSL (cherry picked from commit b7dd0e4) Signed-off-by: Andor Molnar <andor@apache.org>
Latest version of jackson-databind is 2.9.10.2. Change-Id: Id2b0f17c2dfa9a9765fd4893643007b49f06816d Author: Patrick Hunt <phunt@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#1232 from phunt/ZOOKEEPER-3699 (cherry picked from commit 2d29c56) Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
…ster locally When we tested RC 3.6.0, we had a problem of starting ZooKeeper cluster with large number (11+) of ensemble members locally on mac. We found exceptions in the logs when the new MultiAddress feature tries to filter the unreachable hosts from the address list. This involves the calling of the InetAddress.isReachable method with a default timeout of 500ms, which goes down to a native call in java and basically try to do a ping (an ICMP echo request) to the host. Naturally, the localhost should be always reachable. The problem was that on mac we have the ICMP rate limit set to 250 by default. In this patch we: - changed the reachability check behavior by disabling the check if there is only a single address provided (so we wouldn't be able to filter the unreachable addresses anyway). - added and documented a configuration parameter to disable the reachability check for testing. (default: enabled) - added and documented a configuration parameter to set the timeout for the reachability checks. (default: 1000ms) Author: Mate Szalay-Beko <szalay.beko.mate@gmail.com> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1228 from symat/ZOOKEEPER-3698-branch-3.6
… to race Resurrecting an ancient ticket which could be fixed with a simple patch. Jira mentions a scenario when auto purging tool is in use and Zookeeper server could have a race condition when creating snapshot and data directories. (directory auto creating is enabled by default) Double checking the directory existence might help with it. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1225 from anmolnar/ZOOKEEPER-1936 (cherry picked from commit 689c8b2) Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
Upgrade to the latest version of maven dependency checker. Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11 Author: Patrick Hunt <phunt@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1231 from phunt/ZOOKEEPER-3704 (cherry picked from commit 1fbaa26) Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
This PR is about adding SSL support for zkPython, based on the C-binding. I also fixed the zkpython ant build to work with the current maven top-level build. I also added a new python test case to try to connect to ZooKeeper with SSL. You can test this patch in the following way: ``` # cleanup everything, just to be on the safe side: git clean -xdf # on ubuntu 16.4 make sure you have the following packages installed apt-get install -y libcppunit-dev openssl libssl-dev python-setuptools python2.7 python2.7-dev # make a full build (incl. C-client) mvn clean install -DskipTests -Pfull-build # we only support python2, so e.g. on ubuntu 18.4 you need to switch to python2 update-alternatives --install /usr/bin/python python /usr/bin/python2.7 1 # compile and test zkpython cd zookeeper-contrib/zookeeper-contrib-zkpython/ ant compile ant test ``` Author: Mate Szalay-Beko <szalay.beko.mate@gmail.com> Reviewers: andor@apache.org Closes apache#1121 from symat/ZOOKEEPER-3567 and squashes the following commits: a5839cb [Mate Szalay-Beko] Merge remote-tracking branch 'apache/master' into ZOOKEEPER-3567 d25d610 [Mate Szalay-Beko] ZOOKEEPER-3567: fix build issues after top-level ant removal a8869c9 [Mate Szalay-Beko] Merge remote-tracking branch 'apache/master' into HEAD b92f686 [Mate Szalay-Beko] ZOOKEEPER-3567: fix license check issue 0150986 [Mate Szalay-Beko] ZOOKEEPER-3567: removing code duplication: re-use test SSL certificate generator from C-client tests 7d91359 [Mate Szalay-Beko] ZOOKEEPER-3567: add SSL support for zkpython (cherry picked from commit e4758ba) Signed-off-by: Andor Molnar <andor@apache.org>
**Thanks for Lincoln Lee for the original fix!**
In the current implementation, we always get a WARN in server side
("EndOfStreamException: Unable to read additional data from client")
whenever we close a zookeeper handler from the C client. This also happens
in the end of every execution of the command line C client.
The reason is that currently we don't wait for the response from the server
when we initiate the closing of the client connection, and we terminate
the socket on the client side too early.
I tested the patch both on linux and windows. I also tested it both with
NIO and Netty server side socket implementations.
Author: Mate Szalay-Beko <szalay.beko.mate@gmail.com>
Reviewers: Andor Molnar <andor@apache.org>, Norbert Kalmar <nkalmar@apache.org>
Closes apache#1176 from symat/ZOOKEEPER-1105
(cherry picked from commit 57be7ae)
Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
Issue described here: https://issues.apache.org/jira/browse/ZOOKEEPER-3701 Proposing a fix with catching `IOException` within the truncate method to properly return with `false` if truncate fails. Author: Andor Molnar <andor@apache.org> Author: Andor Molnar <andor@cloudera.com> Reviewers: Ivan Kelly <ivank@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org> Closes apache#1233 from anmolnar/ZOOKEEPER-3701 (cherry picked from commit a4bc985) Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
…e all invalid - Purge task uses `FileTxnSnapLog#findNRecentSnapshot`, which's likely to lost data when the recent 3 snapshots are all invalid(a new valid snapshot has not generated yet) and at the same time, Purge task(`e.g ./zkCleanup.sh -n 3`) has started a new round work to clean up the preceding snapshots. we will lose all the data.that's a small probability events, but it's reproducible. - Overall, using `snaplog.findNValidSnapshots` to make sure the purge task tries to retain N valid snapshots(rather than N snapshots) to avoid a risk of data loss. - For the unit test, it's not easy to use the `mock` way for the following reasons: - when we want to test the `dataDir` which some Snapshots are valid, others not.Just writing a little data contents to the snapshot to make it valid/invalid has a better flexibility. - too much code changes in the `PurgeTxnTest.java`(pass the original UT) and `FileTxnSnapLog.java`(have some handles) - more details in the [ZOOKEEPER-3231](https://issues.apache.org/jira/browse/ZOOKEEPER-3231) Author: maoling <maoling199210191@sina.com> Reviewers: enixon@apache.org, andor@apache.org Closes apache#1079 from maoling/ZOOKEEPER-3231 and squashes the following commits: 674175b [maoling] setUp() & tearDown(). 472dfd3 [maoling] ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid (cherry picked from commit 2abdfbc) Signed-off-by: Andor Molnar <andor@apache.org>
….6.0 - part2 - upgrade to Apache Parent 23 - disable maven remote plugin - move source assembly execution before sources generation - move git properties resolution to the correct phase Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes apache#1238 from eolivelli/fix/ZOOKEEPER-3695-part2 (cherry picked from commit d3ce1fa) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708 (cherry picked from commit 68e1f7d) Signed-off-by: Andor Molnar <andor@apache.org>
… committed Updated version number in two pom.xml files. Change-Id: I71194499cac0275eb6068a9adee8920b3eeb8b11 Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1377 from tamaashu/apache-branch-3.6
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865 (cherry picked from commit f6c9bac) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
…uare brackets Author: Mohammad Arshad 72626 <mohammad.arshad@huawei.com> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1398 from arshadmohammad/ZOOKEEPER-3878-master (cherry picked from commit f362313) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
As part of the new CI instance migration we wanted to take advantage of Jenkinsfile based pipelines. From now on we're able to script and source control our main Jenkins settings. This patch only adding the Jenkinsfile itself to all major branches: master, branch-3.6 and branch-3.5. Once it's in I'll create the Jenkins job which will use it. Currently I have a testing job based on my ZK fork: https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-master-maven-multipipeline/ Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1409 from anmolnar/ZOOKEEPER-3896 (cherry picked from commit d1c40dd) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Looks like that PollSCM trigger will trigger another build on the same ref if other builds haven't completed rather than haven't started. I change the polling interval to hourly to let other builds finish in time. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1413 from anmolnar/ZOOKEEPER-3896_2 (cherry picked from commit 5de840c) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
PollSCM trigger triggers a build every time it scans the ZooKeeper repo regardless the branch pointer has been changed or not. Instead, I try to use the built-in 'Scan Multibranch Pipeline' instead which should be good for the same purpose. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1415 from anmolnar/ZOOKEEPER-3896 (cherry picked from commit 1c41e12) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
SocketChannel.connect() can throw different kind of exceptions but ClientCnxnSocketNIO.connect() handles only IOException. This could lead to FD leak when socked is opened but is not connected. We should handle some additional exception classes and close the socket. Author: Alexey.Saltanov <Alexey.Saltanov@billing.ru> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1410 from saltos/ZOOKEEPER-3112 (cherry picked from commit 6a8728d) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…le concurrent builds Further improvements to our Jenkinsfiles. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1416 from anmolnar/ZOOKEEPER-3896 (cherry picked from commit 2898ffd) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Modified host and IP parsing logic for IPV6 Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1395 from arshadmohammad/ZOOKEEPER-3876 (cherry picked from commit c9f1521) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
…ti operation https://issues.apache.org/jira/browse/ZOOKEEPER-3895 Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: tison <wander4096@gmail.com>, Mate Szalay-Beko <symat@apache.org> Closes apache#1407 from eolivelli/fix/ZOOKEEPER-3895 (cherry picked from commit ce523e0) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
See the comments in the JIRA issue. Author: Tudor Bosman <tudor@rockset.com> Reviewers: Mate Szalay-Beko <symat@apache.org>, Damien Diederen <dd@crosstwine.com>, Enrico Olivelli <eolivelli@apache.org> Closes apache#1403 from tudor/htlocking1 (cherry picked from commit b776b23) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…nts even though their certificate authentication has failed (3.6) Backport to branch-3.6 Netty channel doesn't get closed if authentication fails after a successful SSL handshake. We need a custom authentication provider in order to trigger this, because the default implementation does the same check as for the SSL handshake. Hence it never fails. Unit test added to make sure client is not able to connect. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>, Norbert Kalmar <nkalmar@apache.org> Closes apache#1427 from anmolnar/ZOOKEEPER-3905_36
Recently I noticed some weird null pointer exception issues during compile in out new builds. I usually resolve this by a full "git clean" locally, so I added it to the Jenkinsfiles too. Author: Andor Molnar <andor@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1431 from anmolnar/ZOOKEEPER-3896
- Upgrade Netty to its latest version 4.1.50.Final which includes both security fixes and AArch64 performance improvements Refer release notes for detail: https://netty.io/news/2020/05/13/4-1-50-Final.html - Upgraded surefire to 3.0.0-M5 due to compatibility Author: odidev <odidev@puresoftware.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1428 from odidev/netty_upgrade (cherry picked from commit e16361d) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Currently, the documentation for this property just mentions TBD (check https://zookeeper.apache.org/doc/r3.5.7/zookeeperAdmin.html). I believe this was ignored until versions 3.5.7 (https://issues.apache.org/jira/browse/ZOOKEEPER-3674) and a fix was made. It will be good to add some documentation around it. Author: Sankalp Bhatia <sankalpbhatia92@gmail.com> Author: Sankalp <sankal@amazon.com> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1405 from sankalpbhatia/master (cherry picked from commit fa846cb) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…ooKeeper/ Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Christopher Tubbs <ctubbsii@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1440 from eolivelli/fix/ZOOKEEPER-3801-2 (cherry picked from commit 9c3281f) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…n the binary tarball in 3.6.2 rc0 - Fix license file names - Remove legacy pom.template file (for Ant based build ?) Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: andor@apache.org Closes apache#1449 from eolivelli/fix/ZOOKEEPER-3924-netty-lic (cherry picked from commit d33193a) Signed-off-by: Andor Molnar <andor@apache.org>
Add the following metrics: * Max/Min/Avg latency for read and write requests. * Total request count for read and write requests. * Connection/session create and close count.
….6.2-1 Add various operational metrics
rahulrane50
pushed a commit
to linkedin/zkbridge
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: do not use. This PR was created as a reference to use for TODOs in the code to track the difference more easily from the OSS patch from Twitter.
This PR includes the following changes:
More detailed implementation notes are available below:
POJO
Interface
BackupStorageProviderLogic/classes that were changed and implemented anew:
org.apache.zookeeper.server.persistence.Util
Util.getZxidRangeFromName
the difference between BackupUtil.getZxidRangeFromName is that the return value is different.
this one needs to return ZxidRange whereas BackupUtil's returns Range
FileTxnSnapLog.findValidSnapshots(long start, long end)
Style changes:
getZxidRangeFromName()-> just use one range instead of having it in Util and BackupUtil since we are going to continue creating snapshots with one Zxid (lastProcessedZxid)