Fix builds with VS 17.6 #4129
Merged
Fix builds with VS 17.6 #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run test-all |
MaceWindu
requested review from
igor-tkachev,
sdanyliv,
viceroypenguin,
jods4 and
Shane32
as code owners
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
btw, local testing (and I suspect Azure after it updated) probably broken in 17.6 for us (microsoft/vstest#4467). Test discovery just crashes, I think I managed to see tests only once after 10+ discoveries |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
igor-tkachev
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it will cause issues with CI, we will merge it after Azure update to 17.6