Skip to content

Commit

Permalink
test: remove non-working concurrency tests for now
Browse files Browse the repository at this point in the history
  • Loading branch information
iiroj committed Nov 27, 2019
1 parent 4bf94e2 commit 0eedacd
Showing 1 changed file with 0 additions and 75 deletions.
75 changes: 0 additions & 75 deletions test/runAll.unmocked.spec.js
Expand Up @@ -133,81 +133,6 @@ describe('runAll', () => {
expect(await readFile('test.js')).toEqual(testJsFilePretty)
})

it('Should succeed when conflicting tasks sequentially edit a file', async () => {
await appendFile('test.js', testJsFileUgly)

await fs.mkdir(cwd + '/files')
await appendFile('file.js', testJsFileUgly, cwd + '/files')

await execGit(['add', 'test.js'])
await execGit(['add', 'files'])

const success = await gitCommit({
config: {
'file.js': ['prettier --write', 'git add'],
'test.js': files => {
// concurrent: false, means this should still work
fs.removeSync(`${cwd}/files`)
return [`prettier --write ${files.join(' ')}`, `git add ${files.join(' ')}`]
}
},
concurrent: false
})

expect(success).toEqual(true)
})

it('Should fail when conflicting tasks concurrently edit a file', async () => {
await appendFile('test.js', testJsFileUgly)
await appendFile('test2.js', testJsFileUgly)

await fs.mkdir(cwd + '/files')
await appendFile('file.js', testJsFileUgly, cwd + '/files')

await execGit(['add', 'test.js'])
await execGit(['add', 'test2.js'])
await execGit(['add', 'files'])

const success = await gitCommit({
config: {
'file.js': ['prettier --write', 'git add'],
'test.js': ['prettier --write', 'git add'],
'test2.js': files => {
// remove `files` so the 1st command should fail
fs.removeSync(`${cwd}/files`)
return [`prettier --write ${files.join(' ')}`, `git add ${files.join(' ')}`]
}
},
concurrent: true
})

expect(success).toEqual(false)
})

it('Should succeed when conflicting tasks concurrently (max concurrency 1) edit a file', async () => {
await appendFile('test.js', testJsFileUgly)

await fs.mkdir(cwd + '/files')
await appendFile('file.js', testJsFileUgly, cwd + '/files')

await execGit(['add', 'test.js'])
await execGit(['add', 'files'])

const success = await gitCommit({
config: {
'file.js': ['prettier --write', 'git add'],
'test2.js': files => {
// concurrency of one should prevent save this operation
fs.removeSync(`${cwd}/files`)
return [`prettier --write ${files.join(' ')}`, `git add ${files.join(' ')}`]
}
},
concurrent: 1
})

expect(success).toEqual(true)
})

it('Should commit entire staged file when no errors and linter modifies file', async () => {
// Stage multiple ugly files
await appendFile('test.js', testJsFileUgly)
Expand Down

0 comments on commit 0eedacd

Please sign in to comment.