v11.2.4 is broken for config .lintstagedrc #1032

9jaGuy · 2021-10-24T11:50:12Z

Description

Steps to reproduce

upgrade to v11.2.4, and run npx lint-staged
nothing happens, it starts working after downgrading to v11.2.3

Environment

OS: Windows
Node.js: v14.17.6
lint-staged: v11.2.4

The text was updated successfully, but these errors were encountered:

iiroj · 2021-10-24T11:52:49Z

Please post your debug logs from npx lint-staged --debug.

9jaGuy · 2021-10-24T11:59:46Z

Sure, I can downgrade and try again but I don't remember seeing anything in the log.

kinda what I meant by nothing happens

9jaGuy · 2021-10-24T12:01:43Z

w3nda · 2021-10-24T13:24:50Z

I'm having something similar on unix.
lint-staged using husky is suddenly failing, no error, no debug.

EDIT

Using a macbook on macOS Big Sur 11.6
Using husky and lint staged on pre-commit, this is suddenly failing

iiroj · 2021-10-24T13:36:57Z

Probably related to this: #981.

Let me open a revert PR.

iiroj · 2021-10-24T14:37:21Z

Hmm, I cannot reproduce this myself on macOS 11.6.

~/git/iiro.fi master*
❯ npx lint-staged       
→ No staged files match any configured task.

~/git/iiro.fi master*
❯ npx lint-staged --version
11.2.4

~/git/iiro.fi master*
❯ npx lint-staged          
✔ Preparing...
⚠ Running tasks...
  ↓ No staged files match *.{js,jsx} [SKIPPED]
  ❯ Running tasks for *.{ts,tsx}
    ✖ eslint --ext .ts,.tsx -- [FAILED]
↓ Skipped because of errors from tasks. [SKIPPED]
✔ Reverting to original state because of errors...
✔ Cleaning up...

✖ eslint --ext .ts,.tsx --:

/Users/iiro/git/iiro.fi/site/src/index.tsx
  5:1  error  Delete `⏎⏎⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Can you try if lint-staged --help or lint-staged --version work?

w3nda · 2021-10-24T14:45:26Z

Yes both are working, I can see the failure when running

yarn lint-staged

And this has worked until v11.2.4

koshic · 2021-10-24T14:49:22Z

Have the same issue with 11.2.4 - exit 1 without any output. maxOS 11.6, yarn 3.0.2

--version & --help work as expected

iiroj · 2021-10-24T15:19:19Z

@w3nda or @VladimirGrenaderov, can you try editing lint-staged? directly in your project via node_modules to add some debug messages?

So edit this file node_modules/lint-staged/lib/index.js and add:

+++ try {
      const resolved = configObject
          ? { config: configObject, filepath: '(input)' }
          : await loadConfig(configPath)
+++ } catch (error) {
+++     console.error(error)
+++     process.exit(1)
+++   }

This might indicate if the bug is indeed with lilconfig.

w3nda · 2021-10-24T15:29:25Z

@iiroj yes, I am getting this error

$ /Users/wenda/apps/acs-sc-web-platform/node_modules/.bin/lint-staged
TypeError: Cannot read property 'load' of undefined
    at jsYamlLoad (/Users/wenda/apps/acs-sc-web-platform/node_modules/lint-staged/lib/index.js:28:48)
    at Object.search (/Users/wenda/apps/acs-sc-web-platform/node_modules/lilconfig/dist/index.js:126:37)
    at async lintStaged (/Users/wenda/apps/acs-sc-web-platform/node_modules/lint-staged/lib/index.js:101:9)

iiroj · 2021-10-24T15:32:41Z

@w3nda That looks like the explorer.load method returned from lilconfig here:

https://github.com/okonet/lint-staged/blob/04529e2b9040adc54cc8e5efc66b95bc0023477c/lib/index.js#L50
https://github.com/okonet/lint-staged/blob/04529e2b9040adc54cc8e5efc66b95bc0023477c/lib/index.js#L31
https://github.com/okonet/lint-staged/blob/04529e2b9040adc54cc8e5efc66b95bc0023477c/lib/index.js#L3

Do you have the module installed? Maybe you could try removing your node_modules and reinstalled if not.

w3nda · 2021-10-24T15:38:07Z

I have lilconfig installed at 2.0.3, I just reinstalled it and getting the same error.

iiroj · 2021-10-24T15:39:30Z

Are you by chance using yaml configuration? That was the one thing not supported directly by lilconfig.

koshic · 2021-10-24T15:42:00Z

Are you by chance using yaml configuration? That was the one thing not supported directly by lilconfig.

But it should be reflected in documentation, right? I use .yaml too.

w3nda · 2021-10-24T15:42:16Z

No, I am not using lilconfig directly, and am using lint-staged through husky.

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn lint-staged

iiroj · 2021-10-24T15:43:51Z

@VladimirGrenaderov there was a compatibility "fix" in PR #981 that should have handled the yaml configurations, but it seems to be broken. I now managed to replicate the bug so I'll try and come up with a fix. Sorry about that!

iiroj · 2021-10-24T15:54:22Z

@9jaboy @w3nda and @VladimirGrenaderov the fix was pretty simple, but it seems we don't cover this code via tests:
#1033

kelvindecosta · 2021-10-24T16:09:11Z

Hey everyone!

Ran into the same issue on Linux.
yarn lint-staged exits with 1.

I think the issue is with the resolveConfig function.
For some reason, it works when I rename .lintstagedrc -> .lintstagedrc.json.

Hope this helps!

iiroj · 2021-10-24T16:13:39Z

Thanks @kelvindecosta, I opened a PR that will fix the issue: #1033

tg970 · 2021-10-25T21:16:51Z

I can also confirm this is an issue in our projects. OSX 11.6, Node 16.10.0, lint-staged 11.2.4. Running npx lint-staged produces nothing. Is there any way we could expedite PR #1033 ? Hoping to not have to go touch each one of our repos to get up and running again. Thanks!!

ninezero90hy · 2021-10-26T06:36:48Z

I was confused.
This problem needs to be solved quickly!

aaronadamsCA · 2021-10-26T12:16:23Z

Works, thanks! 🙌

PaulRBerg · 2021-10-26T12:21:44Z

Hey @aaronadamsCA, you mean it works with v11.2.5, don't you?

Update: yeah I can confirm that it works with v11.2.5

si-saaref · 2021-11-10T06:47:53Z

@kelvindecosta I was confused i have some issue i try to use your advice but i can't find where .lintstagedrc..
Where is it? Could you tell me?

si-saaref · 2021-11-10T06:52:51Z

While i run with yarn lint-staged everything run normally, but when i tried to use npx lint-staged it show error that yarn is not recognized as internal command

`$ npx lint-staged --debug
Running lint-staged with the following config:
{
'.{js,jsx}': 'yarn lint:fix',
'.{js,jsx,json,css,md}': 'yarn prettier:fix'
}
[STARTED] Preparing...
[SUCCESS] Preparing...
[STARTED] Running tasks...
[STARTED] Running tasks for *.{js,jsx}
[STARTED] Running tasks for *.{js,jsx,json,css,md}
[STARTED] yarn lint:fix
[STARTED] yarn prettier:fix
[FAILED] yarn lint:fix [FAILED]
[FAILED] yarn lint:fix [FAILED]
[FAILED] yarn prettier:fix [FAILED]
[FAILED] yarn prettier:fix [FAILED]
[SUCCESS] Running tasks...
[STARTED] Applying modifications...
[SKIPPED] Skipped because of errors from tasks.
[STARTED] Reverting to original state because of errors...
[SUCCESS] Reverting to original state because of errors...
[STARTED] Cleaning up...
[SUCCESS] Cleaning up...

✖ yarn lint:fix:
'yarn' is not recognized as an internal or external command,
operable program or batch file.

✖ yarn prettier:fix:
'yarn' is not recognized as an internal or external command,
operable program or batch file.`

kelvindecosta · 2021-11-10T07:15:51Z

Hey @si-saaref

.lintstagedrc is the configuration file.
In your case, it would be the file with this content:

{
  ".{js,jsx}": "yarn lint:fix",
  ".{js,jsx,json,css,md}": "yarn prettier:fix"
}

As for your error, yarn must be installed on your system globally like so:

npm i -g yarn

Hope this helps!

si-saaref · 2021-11-10T08:25:05Z

@kelvindecosta Yes i have created .lintstagedrc.json with the content as you said and also install yarn globally..
Then i try to commit again and it thrown an error same as before

aaronadamsCA · 2021-11-10T10:44:12Z

Hey @si-saaref, the bug described in this issue was fixed as of v11.2.5. If you're using an updated version of lint-staged, then you don't need any of the specific advice offered in this thread, because you won't run into this specific issue anymore.

This isn't a great place to ask for general support. But, I've included some below anyway.

It looks like you're trying to use two different package managers at once:

npx is a command provided by NPM, the built-in Node.js package manager.
yarn is a command provided by Yarn, a competing package manager you can optionally install.

You should choose one package manager for your project and stick with it. Each has its advantages and disadvantages. At a very high level, Yarn 3 is easier to use, but harder to set up; NPM 8 is built into Node.js 16, but harder to use.

If you want to use NPM, you will run npx lint-staged, and your .lintstagedrc will look something like this:

{
  ".{js,jsx}": "npm run-script lint:fix",
  ".{js,jsx,json,css,md}": "npm run-script prettier:fix"
}

And then going forward, any time you see a command that includes yarn, you will need to learn how to rewrite it for NPM.

Package management is one of the least welcoming aspects of the Node.js ecosystem. Many docs and tutorials will assume you use either NPM or Yarn (and often older, incompatible versions, too). But once you learn how to adjust commands for your package manager of choice, it should be smooth sailing.

If you need further assistance, I'd recommend searching and asking on Stack Overflow: https://stackoverflow.com/tags/node.js

DeadLoss1801 · 2023-07-12T04:44:40Z

"scripts": {
"test": "mocha"
},

try this

iiroj mentioned this issue Oct 24, 2021

fix: correctly import js-yaml to fix yaml config loading #1033

Merged

iiroj linked a pull request Oct 24, 2021 that will close this issue

Reduce dependencies size #981

Merged

1 task

9jaGuy changed the title ~~v11.2.4 is broken on Windows~~ v11.2.4 is broken for config .lintstagedrc Oct 24, 2021

chillyistkult mentioned this issue Oct 26, 2021

npx commands not working typicode/husky#1066

Closed

dangreen mentioned this issue Oct 26, 2021

Revert "chore(deps-dev): bump lint-staged from 11.2.3 to 11.2.4" reactchartjs/react-chartjs-2#811

Merged

aaronadamsCA mentioned this issue Oct 26, 2021

Husky pre-commit fails with code 1 (error) typicode/husky#1014

Closed

iiroj closed this as completed in #1033 Oct 26, 2021

gael-ian mentioned this issue Oct 26, 2021

11.2.5 breaks config loading #1034

Closed

iiroj mentioned this issue Oct 26, 2021

fix: revert back to cosmiconfig from lilconfig #1035

Merged

frantuma mentioned this issue Oct 29, 2021

Turn off husky and lint staged during release swagger-api/apidom#838

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v11.2.4 is broken for config .lintstagedrc #1032

v11.2.4 is broken for config .lintstagedrc #1032

9jaGuy commented Oct 24, 2021

iiroj commented Oct 24, 2021

9jaGuy commented Oct 24, 2021 •

edited

9jaGuy commented Oct 24, 2021

w3nda commented Oct 24, 2021 •

edited

iiroj commented Oct 24, 2021

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021 •

edited

koshic commented Oct 24, 2021 •

edited

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

koshic commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

iiroj commented Oct 24, 2021 •

edited

kelvindecosta commented Oct 24, 2021

iiroj commented Oct 24, 2021

tg970 commented Oct 25, 2021

ninezero90hy commented Oct 26, 2021 •

edited

aaronadamsCA commented Oct 26, 2021

PaulRBerg commented Oct 26, 2021 •

edited

si-saaref commented Nov 10, 2021

si-saaref commented Nov 10, 2021

kelvindecosta commented Nov 10, 2021

si-saaref commented Nov 10, 2021

aaronadamsCA commented Nov 10, 2021

DeadLoss1801 commented Jul 12, 2023

v11.2.4 is broken for config .lintstagedrc #1032

v11.2.4 is broken for config .lintstagedrc #1032

Comments

9jaGuy commented Oct 24, 2021

Description

Steps to reproduce

Environment

iiroj commented Oct 24, 2021

9jaGuy commented Oct 24, 2021 • edited

9jaGuy commented Oct 24, 2021

w3nda commented Oct 24, 2021 • edited

iiroj commented Oct 24, 2021

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021 • edited

koshic commented Oct 24, 2021 • edited

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

koshic commented Oct 24, 2021

w3nda commented Oct 24, 2021

iiroj commented Oct 24, 2021

iiroj commented Oct 24, 2021 • edited

kelvindecosta commented Oct 24, 2021

iiroj commented Oct 24, 2021

tg970 commented Oct 25, 2021

ninezero90hy commented Oct 26, 2021 • edited

aaronadamsCA commented Oct 26, 2021

PaulRBerg commented Oct 26, 2021 • edited

si-saaref commented Nov 10, 2021

si-saaref commented Nov 10, 2021

kelvindecosta commented Nov 10, 2021

si-saaref commented Nov 10, 2021

aaronadamsCA commented Nov 10, 2021

DeadLoss1801 commented Jul 12, 2023

9jaGuy commented Oct 24, 2021 •

edited

w3nda commented Oct 24, 2021 •

edited

w3nda commented Oct 24, 2021 •

edited

koshic commented Oct 24, 2021 •

edited

iiroj commented Oct 24, 2021 •

edited

ninezero90hy commented Oct 26, 2021 •

edited

PaulRBerg commented Oct 26, 2021 •

edited