Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and restore "supports-color" #1264

Closed
wants to merge 3 commits into from
Closed

Update deps and restore "supports-color" #1264

wants to merge 3 commits into from

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Mar 5, 2023

This PR updates all dependencies, and also restores supports-colors in place of colorette's util, because a commenter mentioned that downgrading lint-staged from 13 to 12 fixed their (Windows) terminal output issues.

I figured removal of supports-color might be related, since it happened in 13.0.0. The reason behind was to simplify dependencies because listr2 uses it internally.

I opened this in the next branch to get an npm release that people could test.

@iiroj
Copy link
Member Author

iiroj commented Mar 5, 2023

FYI, @okonet

@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (f230c69) 100.00% compared to head (c01d952) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          735       735           
  Branches       198       198           
=========================================
  Hits           735       735           
Impacted Files Coverage Δ
lib/figures.js 100.00% <100.00%> (ø)
lib/messages.js 100.00% <100.00%> (ø)
lib/resolveTaskFn.js 100.00% <100.00%> (ø)
lib/runAll.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Ping @okonet I'm getting feedback on the linked issues that restoring supports-color indeed improves the situation in that it doesn't show duplicate output but rather falls back to the simpler renderer more easily.

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Originally I migrated to colorette because that's what listr2 uses under the hood, but looks like we should still keep on using chalk/supports color for better compatibility...

@okonet
Copy link
Collaborator

okonet commented Mar 6, 2023

I guess let's revert then?

@okonet
Copy link
Collaborator

okonet commented Mar 6, 2023

Maybe not the whole PR but just the color related stuff?

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Yeah I think for now this PR is all we need, since it fixes the detection. 👍 I can clean up the color functions separately later, they're not critical.

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Or actully, let me check quickly if it's a big task to fix the color functions.

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

@okonet it was pretty straightforward, so I pushed a commit into this PR. 👍

Looks like semantic-release created git version tags from this next branch... It did tag the releases correctly as pre-release, but I think we'll run into trouble if you don't first manually remove these from GitHub; sorry about the trouble:

  1. first delete both the releases from GitHub:
    1. https://github.com/okonet/lint-staged/releases/tag/v13.1.3
    2. https://github.com/okonet/lint-staged/releases/tag/v13.1.4
  2. then delete both the tags themselves from the tags page via the ... menu: https://github.com/okonet/lint-staged/tags

Screenshot 2023-03-06 at 19 34 24

@iiroj iiroj closed this Mar 6, 2023
@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Just in case, I opened a new PR in a different branch name than next.

@iiroj
Copy link
Member Author

iiroj commented Mar 6, 2023

Turns out I had permissions to delete the tags and releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants