Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make test runs robust against a non-"master" defaultBranch #1271

Closed
wants to merge 1 commit into from

Conversation

marcelltoth
Copy link
Contributor

Summary

This is a tiny fix related to my contribution at #1270 .

When running the tests locally they were failing because my init.defaultBranch is set to main (was a requirement for some other work). Some of the tests make assumption about the branch name, and will fail if it's not master.

This tiny change makes the test runs more robust by specifying the initial branch name explicitly. This will also shield against any future changes in the default value of the property. This may very well happen, see git docs:
image

@okonet
Copy link
Collaborator

okonet commented Mar 8, 2023

Can we change it to main instead?

@marcelltoth
Copy link
Contributor Author

marcelltoth commented Mar 8, 2023

Can we change it to main instead?

We sure can, but that requires changing the tests that mention master to main. I can do that if you'd like me to. Should I?

@marcelltoth marcelltoth changed the title Make test runs robust against a non-"master" defaultBranch test: make test runs robust against a non-"master" defaultBranch Mar 9, 2023
@iiroj
Copy link
Member

iiroj commented Jun 28, 2023

Sorry, this has become stale. A similar fix will be included in #1303 so closing this.

We can change everything from master to main at some point, but let's do it separately.

@iiroj iiroj closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants