Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Version Bump #1272

Merged
merged 1 commit into from Mar 10, 2023
Merged

Minor Version Bump #1272

merged 1 commit into from Mar 10, 2023

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Mar 8, 2023

This PR bumps a minor version, making it possible to publish a new npm version under the latest tag. From this PR semantic-release inadvertently released patch versions to next without adding the -next postfix.

It also disables semantic-release from running for the next branch, until the issue is solved.

@iiroj iiroj requested a review from okonet March 8, 2023 16:11
@iiroj
Copy link
Member Author

iiroj commented Mar 8, 2023

Ping @okonet this should trigger publishing of version 13.2.0 to npm with:

  • fix(dependencies): replace colorette with chalk for better color support detection
  • fix: use index-based stash references for improved MSYS2 compatibility (#1270)
  • feat: version bump only

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (52a650b) 100.00% compared to head (55e5436) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          733       733           
  Branches       197       197           
=========================================
  Hits           733       733           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Changes in `semantic-release` seem to make it difficult to publish pre-releases
into `lint-staged@next`, so disable it for now. For more info, see the following PR:
#1265
@iiroj
Copy link
Member Author

iiroj commented Mar 10, 2023

Ping @okonet what do you think? Currently semantic-release is stuck trying to release patch versions that already in npm under the next tag. This will trigger a minor version bump to workaround the issue while also keeping the version sequence correct by not skipping any patch versions.

@okonet
Copy link
Collaborator

okonet commented Mar 10, 2023

Go for it. I’ll try to look into changesets soon.

@iiroj iiroj merged commit f4351e3 into master Mar 10, 2023
17 checks passed
@iiroj iiroj deleted the feat-bump-version branch March 10, 2023 08:03
@iiroj
Copy link
Member Author

iiroj commented Mar 10, 2023

Heh, looks like GitHub dropped my empty commit so it failed yet again.

Should I just push directly to master an empty commit feat: version bump only?

@okonet
Copy link
Collaborator

okonet commented Mar 10, 2023

Yeah sure go ahead.

@iiroj
Copy link
Member Author

iiroj commented Mar 10, 2023

Ping @okonet , looks like I can't do it:

remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: At least 1 approving review is required by reviewers with write access. 9 of 9 required status checks are expected.        

If you can do it, it's roughly:

git checkout master
git commit --allow-empty -m "feat: version bump only"
git push origin master

@okonet
Copy link
Collaborator

okonet commented Mar 10, 2023

I can't do it since it's protected. You can lift the protection but maybe we postpone and I'll take a look at changesets next week? This kind of issues with semantic release drive me nuts.

@iiroj
Copy link
Member Author

iiroj commented Mar 10, 2023

Let's try one last time with this PR #1275, if it still fails we can just wait for changesets. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants