-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to 🦋 changesets #1314
Migrate to 🦋 changesets #1314
Conversation
a1cdd80
to
033292d
Compare
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
ba082f0
to
b666e8b
Compare
Ping @okonet you might want to install the Changesets bot to this repo: https://github.com/apps/changeset-bot |
I'll copy a similar implementation to one of my own repos to make sure it works as expected. |
Had to tweak it more than expected, but got it working here: https://github.com/iiroj/iiro.fi
I mostly had to tweak the version commands to get the https://github.com/iiroj/iiro.fi/blob/0b69b1010e3119183dfc7ad4d23e27037dc450c6/package.json#L17-L18
and run |
I generated the |
Ping @okonet it would be nice to test dropping Node.js 16 support using changesets. It goes EOL in two days, on September 11th 2023: https://nodejs.dev/en/about/releases/ |
Sure let’s give it a go. What’s required from my end? Approval or do I need to test it somehow? |
I tested and synced this config with the https://github.com/iiroj/iiro.fi repo, so after this PR is merged, versioning should happen via 🦋 changesets. Since this PR has an empty changeset file, no automatic version PR should be opened. After I create a new PR for the Node.js 16 deprecation with a changeset file, we should see some new functionality. So, should I just merge this? |
This PR is for random cleanup targeted at preparing to switch to 🦋 changesets, by:
commitlint
for linting commit messages according to the conventional commits specificationadjusting the current semantic-release job to useconventionalcommits
instead of defaultangular
master
(or PR targetingmaster
)npm ci
CI step into its own separate job with caching...and finally:
changesets