Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use built-in exec instead of execa with execGit #1379

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

iiroj
Copy link
Member

@iiroj iiroj commented Dec 20, 2023

No description provided.

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: a36161e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lint-staged Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iiroj
Copy link
Member Author

iiroj commented Dec 20, 2023

Ping @okonet do you have any opinion on reducing the number of dependencies? This Draft MR is a trial on whether current fresh Node.js LTS versions would allow us to drop execa and just directly use spawn(). Looks like there's plenty of improvements and the syntax is quite nice.

Hoping that Windows tests pass.... 🤞

@okonet
Copy link
Collaborator

okonet commented Dec 20, 2023

I'm fine with it. Looks nice indeed. Why are user tasks need still to be wrapped with execa? Can they use this wrapper? Or did I misunderstand this part?

@iiroj
Copy link
Member Author

iiroj commented Dec 20, 2023

This was easier to test with, thus the draft PR. For user tasks it will still need:

  • shell support
  • support for aborting, possibly with a signal
  • some refactoring because current code passes the execa result object around (mostly unnecessary)

@okonet
Copy link
Collaborator

okonet commented Dec 21, 2023

That makes sense. I'm wondering if it then worth the change if we keep the dependency in place.

Can these missing bits be done just with Node?

@iiroj
Copy link
Member Author

iiroj commented Dec 21, 2023

Should be possible. I'll keep this as a draft until it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants