ci: test on Node.js 6, 8, 10 and 11 #525
Conversation
| - nodejs_version: '8' | ||
| - nodejs_version: '6' |
There was a problem hiding this comment.
This package doesn't support Node 6. Minimum requirement is Node 8.6
There was a problem hiding this comment.
Well, then it should be made clear in the engines field. Otherwise people might run it on older versions.
There was a problem hiding this comment.
Not an ideal solution tbh, yarn --ignore engines is recommended because the current solution provides no consistent behavior across different platforms. What if you run a CI runner on your pc?
There was a problem hiding this comment.
What do you mean by a CI runner?
There was a problem hiding this comment.
GitLab runner, SSH runner, tools like Surf / Deployer, ... which we use in CI and locally.
There was a problem hiding this comment.
Sorry I’m not following. I think the solution is okay since 🚫💩 lint-staged isn’t supposed to be used on CI so it shouldn’t break it. We have safety nets built in for runtime.
| @@ -4,9 +4,10 @@ | |||
|
|
|||
| language: node_js | |||
| node_js: | |||
| - 'node' | |||
There was a problem hiding this comment.
What does this mean? Which version is it going to be?
There was a problem hiding this comment.
node is the current stable which is 11 at the moment.
| - '8' | ||
| - '6' |
There was a problem hiding this comment.
After adding engines to package.json, yes.
|
Closing this as stale, but opened a new one at #646 |
Node.js 9 was a short living branch and we should also test on the current LTS and stable branches.
See https://github.com/nodejs/Release/blob/master/README.md