Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resolver to ignore currently set GIT_DIR #628

Closed

Conversation

carnun
Copy link
Contributor

@carnun carnun commented Jun 12, 2019

A potential fix for #627

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #628 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   98.15%   98.15%   +<.01%     
==========================================
  Files          14       14              
  Lines         379      380       +1     
  Branches       53       53              
==========================================
+ Hits          372      373       +1     
  Misses          7        7
Impacted Files Coverage Δ
src/resolveGitDir.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffef73...813b495. Read the comment docs.

@carnun carnun force-pushed the fix-resolver-git-dir-issue627 branch from 107167b to 813b495 Compare June 12, 2019 12:47
@vadimka123
Copy link

Updating git to latest version (2.21.0) resolve issue
Not need this changes

@okonet
Copy link
Collaborator

okonet commented Jun 13, 2019

Interesting! Can you please check out failing tests?

@okonet
Copy link
Collaborator

okonet commented Jun 13, 2019

Closed in favor of #629

@okonet okonet closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants