fix: create fn title with mock file list of correct length #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 99.67% 99.67% +<.01%
==========================================
Files 11 11
Lines 307 309 +2
Branches 63 64 +1
==========================================
+ Hits 306 308 +2
Misses 1 1
Continue to review full report at Codecov.
|
VitorLuizC
approved these changes
Oct 4, 2019
okonet
approved these changes
Oct 8, 2019
|
🎉 This PR is included in version 9.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake on #706 where the title for function tasks is generated by creating a mock array of filenames with the length of the matched functions, when it instead should be the the length of the staged files array. This causes failures with function linters in some situations.
Should fix the problem reported by @VitorLuizC in #706 (comment).