If cwd is not same as gitDir

[ram3shyadav]

No description provided.

[iiroj]

When using the relative option, files are relative to the cwd, which might be different from the git dir. Is this what you mean?

I think git commands can now also always run in the cwd, which would fix the issue.

[ram3shyadav]

When using the relative option, files are relative to the cwd, which might be different from the git dir. Is this what you mean?

I think git commands can now also always run in the cwd, which would fix the issue.

yes,

and its not fixed.

If my package.json file is not in root/cwd thn git add is failing after linters

[iiroj]

But can you confirm this only happens when using the relative option? This would then be a new bug after passing only matched files to the git add command.

A straightforward solution would be to resolve the paths before adding them.

I can create a fix tomorrow.

[codecov]

Codecov Report

Merging #856 into master will decrease coverage by 0.49%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##            master     #856      +/-   ##
===========================================
- Coverage   100.00%   99.50%   -0.50%     
===========================================
  Files           17       17              
  Lines          596      602       +6     
  Branches       142      143       +1     
===========================================
+ Hits           596      599       +3     
- Misses           0        3       +3     

Impacted Files	Coverage Δ
lib/gitWorkflow.js	98.00% <57.14%> (-2.00%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885a644...1e1536a. Read the comment docs.

[iiroj]

The correct fix is to resolve to cwd instead of gitDir here: https://github.com/okonet/lint-staged/blob/master/lib/gitWorkflow.js#L253

The working dir can be set to this.cwd in the constructor options.

[ram3shyadav]

The correct fix is to resolve to cwd instead of gitDir here: https://github.com/okonet/lint-staged/blob/master/lib/gitWorkflow.js#L253

The working dir can be set to this.cwd in the constructor options.

To reproduce issue

• create a git repo
• add package.json in a sub folder
• npm install husky
• npm install lint-staged
• use lint-staged entry from package.json with --relative flag in pre-commit config

cwd will be directory of package.json
gitDir will be root folder

git add try to add file from path relative to package.json folder. it should be from git root

App
    .git
    ClientApp
        package.json

[iiroj]

I'll close this PR and opened #857. I'll also add a test case according to your instructions.