fix: ensure supportsColor.level exists before stringifying it #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When supports-color detects a level of 0, it will not return an object containing the key `level`, but instead only `false`. This commit makes sure `supportsColor.level` exists before calling `supportsColor.level.toString()`. The TypeScript definitions of `chalk` seem wrong in this regard, since they imply that if `supportsColor` is truthy, it is an object and always contains the `level` key of type `0 | 1 | 2 | 3`.
iiroj
force-pushed
the
fix-supports-color
branch
from
dd036c9
to
7a5182b
Compare
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 602 602
Branches 142 142
=========================================
Hits 602 602
Continue to review full report at Codecov.
|
|
Ping @okonet can you check this out? |
okonet
approved these changes
Aug 25, 2020
|
🎉 This PR is included in version 10.2.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When supports-color detects a level of 0, it will not return an object containing the key
level, but instead onlyfalse. This commit makes suresupportsColor.levelexists before callingsupportsColor.level.toString().The TypeScript definitions of
chalkseem wrong in this regard, since they imply that ifsupportsColoris truthy, it is an object and always contains thelevelkey of type0 | 1 | 2 | 3.