Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --lint-all-files option #907

Closed

Conversation

victor-xplore
Copy link

Add a --lint-all-files cmd line option to run lint-staged on all files tracked by git

Fixes #889

@victor-xplore
Copy link
Author

Integration tests fail, seems to be same issue as in #906 (comment)

@iiroj
Copy link
Member

iiroj commented Aug 24, 2020

Hello,

Thanks for the PR! Unfortunately, this has already been discussed and I feel it is not in lint-staged's DNA to add support for this.

However, there's (slow) work on allowing use of adapters, mostly for other VCS, that would allow this.

I'll close this PR for now.

@iiroj iiroj closed this Aug 24, 2020
@victor-xplore
Copy link
Author

@iiroj Hi, thank you for having a look, I didn't see any discussion but I guess the feature request I saw could be a duplicate.

While it does goes against the project name, I do find it really useful. Eg when introducing lint-staged to a repository it's nice to make sure all files validate, when working with people who skip the hooks it's nice to validate that the repository is still valid and to run on pull requests to make sure hooks aren't skipped. I guess I'll just have to maintain my own fork for now then.

@iiroj
Copy link
Member

iiroj commented Aug 25, 2020

Sorry about that. Let me reiterate: I'd like to refactor lint-staged to support generic adapters, like --adapter git or adapter --adapter mercurial. After this, we can ship with a default --adapter git-all-tracked-files or something like that, that will do what you want but keep the internals more clean.

@iiroj
Copy link
Member

iiroj commented Aug 25, 2020

Related #892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add an option to run lint-staged on non-staged files
2 participants