fix: quiet mode filter only returns errors

[steveszc]

The quiet mode filter should only return error severity results, this ensures that todo severity results are excluded from the quiet results.

Currently the login filters out only warning results, which leave todos in the set of filtered results. This causes an incorrect errorCount and causes the todos being displayed in the --quiet output, which should not be the case.

fixes #415

[steveszc]

I did not see any tests covering --quiet mode. Seems like this would be good to add, but seemed outside the scope of this pr.

[scalvert]

Hey @steveszc, thanks for the PR! We do have a test for the --quiet flag

eslint-formatter-todo/__tests__/acceptance/eslint-with-todo-formatter-test.ts

Line 247 in 79792ef

it('should filter warn with --quiet', async () => {

[scalvert]

So it's the INCLUDE_TODO flag's presence that determines whether results with the todo severity are included. If this flag isn't present, the results won't include those with todo severity, so I'm not sure your addition would have any effect in that case.

What your change would have an effect on is whether INCLUDE_TODO and --quiet were used in conjunction.

It's probably useful to have a test that covers that specific scenario.

[scalvert]

Thinking about this more, I'm not sure --quiet should exclude todos. Why would I not instead simply omit INCLUDE_TODO rather than having to filter them out? Is there a specific scenario we're trying to address?