Add new compact-after-process feature #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngouy
commented
Oct 4, 2023
Comment on lines
+111
to
+116
| if (compactAfterProcess) { | ||
| const { compacted } = compactTodoStorageFile(baseDir); | ||
|
|
||
| resultsToPrint &&= resultsToPrint + "\n" | ||
| resultsToPrint += `Removed ${compacted - todoInfo.cleanedUp} todos from .lint-todo storage file`; | ||
| } |
There was a problem hiding this comment.
I'm wondering if we should always display the message "x todo were removed" as long as the FLAG/CONST is given (even when none were been removed) or only if flag is given + some where actually removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to combine multiple operation, and then compact the result
So for example we can both cleanup and compact at the same time