pam_access: Support UID and GID in access.conf #186

blueskycs2c · 2020-03-11T07:48:01Z

pam_access: Support UID and GID in access.conf fix #114.

eg:access.conf
-:ALL EXECPT (1000) 1002 :LOCAL

blueskycs2c · 2020-03-17T06:13:35Z

@t8m please take a look ,and let me know if there is any problem.
Thanks!

ldv-alt · 2020-03-17T09:20:22Z

On Wed, Mar 11, 2020 at 12:48:15AM -0700, blueskycs2c wrote: pam_access: Support UID and GID in access.conf fix [#114](#114).

Please make your patch clean from whitespace errors and re-push. Use "git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904" to check. Thanks.

blueskycs2c · 2020-03-17T13:48:25Z

Please make your patch clean from whitespace errors and re-push. Use "git diff --check 4b825dc642cb6eb9a060e54bf8d69288fbee4904" to check. Thanks.
@ldv-alt Thanks for your reply! I have revised it.

ldv-alt · 2020-03-23T15:36:50Z

Could you document the proposed extension in the manual page, please?

blueskycs2c · 2020-03-25T15:46:38Z

Could you document the proposed extension in the manual page, please?

@ldv-alt Thanks for you reply.
I have add the information in access.conf.5.xml and re-push it.

t8m

Please fix the formatting as it is really sloppy. Try to follow the style of the surrounding code.

t8m · 2020-04-15T10:18:59Z

modules/pam_access/pam_access.c

+		  "user_match: tok=%s, item=%s", tok, item->user->pw_name);
+
+     memset(buf,0,BUFSIZ);
+     //tok is uid


Please no C++ style comments.

t8m · 2020-04-15T10:19:41Z

modules/pam_access/pam_access.c

-		  "user_match: tok=%s, item=%s", tok, string);
+		  "user_match: tok=%s, item=%s", tok, item->user->pw_name);
+
+     memset(buf,0,BUFSIZ);


Please spaces after commas

t8m · 2020-04-15T10:19:57Z

modules/pam_access/pam_access.c

@@ -511,14 +511,26 @@ netgroup_match (pam_handle_t *pamh, const char *netgroup,
 static int
 user_match (pam_handle_t *pamh, char *tok, struct login_info *item)
 {
-    char   *string = item->user->pw_name;
+    char *string = NULL ;


Please no space before ;

t8m · 2020-04-15T10:20:19Z

modules/pam_access/pam_access.c

+
+     memset(buf,0,BUFSIZ);
+     //tok is uid
+     if(strspn(tok,"0123456789") == strlen(tok)) {


Please space after if and comma

t8m · 2020-04-15T10:20:38Z

modules/pam_access/pam_access.c

+	 sprintf(buf, "%d", item->user->pw_uid);
+	 if(item->debug)
+		pam_syslog(pamh, LOG_DEBUG, "user_match: tok = %s, uid= %d", tok , item->user->pw_uid);
+	 string = buf ;


no space before ;

t8m · 2020-04-15T10:21:31Z

modules/pam_access/pam_access.c

@@ -588,7 +601,16 @@ group_match (pam_handle_t *pamh, const char *tok, const char* usr,
    memset(grptok, 0, BUFSIZ);
    strncpy(grptok, tok + 1, strlen(tok) - 2);

-    if (pam_modutil_user_in_group_nam_nam(pamh, usr, grptok))
+    if(strspn(grptok, "0123456789") == strlen(grptok)) {


space after if

t8m · 2020-04-15T10:22:09Z

modules/pam_access/pam_access.c

+    if(strspn(grptok, "0123456789") == strlen(grptok)) {
+	grpgid = atoi(grptok);
+
+	if(debug)


space after if

t8m · 2020-04-15T10:22:52Z

modules/pam_access/pam_access.c

+
+	if(debug)
+	   pam_syslog(pamh,LOG_DEBUG,"group_match:grpgid = %d,user= %s",grpgid,usr);
+	// tok is GID


No C++ style comments

t8m · 2020-04-15T10:23:47Z

modules/pam_access/pam_access.c

+	if(debug)
+	   pam_syslog(pamh,LOG_DEBUG,"group_match:grpgid = %d,user= %s",grpgid,usr);
+	// tok is GID
+	if(pam_modutil_user_in_group_nam_gid(pamh,usr,grpgid))


space after if and after commas

t8m · 2020-04-15T10:24:15Z

modules/pam_access/pam_access.c

+	grpgid = atoi(grptok);
+
+	if(debug)
+	   pam_syslog(pamh,LOG_DEBUG,"group_match:grpgid = %d,user= %s",grpgid,usr);


spaces after commas

blueskycs2c · 2020-04-20T03:37:26Z

Please fix the formatting as it is really sloppy. Try to follow the style of the surrounding code.

@t8m Thanks for your reply! I have revise it.

t8m

A few more formatting nits.

t8m · 2020-04-20T08:36:30Z

modules/pam_access/access.conf.5.xml

@@ -179,6 +179,11 @@
    </para>
    <para>-:root:ALL</para>

+    <para>
+      User with uid <emphasis>1003</emphasis> and group with gid <emphasis>1000</emphasis> should be allowed to get access


Please split this overly long line. Also should it be rather 'An user' and 'a group'?

t8m · 2020-04-20T08:38:17Z

modules/pam_access/pam_access.c

+	 if (item->debug)
+		pam_syslog(pamh, LOG_DEBUG, "user_match: tok=%s, uid=%d", tok, item->user->pw_uid);
+	 string = buf;
+


Please drop this empty line.

t8m · 2020-04-20T08:38:38Z

modules/pam_access/pam_access.c

+    /* grptok is GID */
+    if (strspn(grptok, "0123456789") == strlen(grptok)) {
+	grpgid = atoi(grptok);
+


Please drop this empty line.

t8m · 2020-04-20T08:38:54Z

modules/pam_access/pam_access.c

+	   pam_syslog(pamh,LOG_DEBUG,"group_match:grpgid=%d, user=%s", grpgid, usr);
+	if (pam_modutil_user_in_group_nam_gid(pamh, usr, grpgid))
+	   return YES;
+


Please drop this empty line.

t8m · 2020-04-20T08:39:28Z

modules/pam_access/pam_access.c

+	grpgid = atoi(grptok);
+
+	if (debug)
+	   pam_syslog(pamh,LOG_DEBUG,"group_match:grpgid=%d, user=%s", grpgid, usr);


Please spaces after commas, and after ':'.

mluckam · 2023-05-22T18:27:46Z

@t8m @blueskycs2c it appears that the review comments were addressed. Any reason this feature was not merged? Would be useful functionality. Please let me know if I can help.

t8m · 2023-07-25T21:10:57Z

This needs to be rebased to resolve the conflict. I would approve it then.

blueskycs2c force-pushed the access-pr branch from 593378c to cdd0d54 Compare March 17, 2020 13:43

blueskycs2c force-pushed the access-pr branch 2 times, most recently from 59e12e5 to b4cd702 Compare March 25, 2020 15:41

t8m requested changes Apr 15, 2020

View reviewed changes

blueskycs2c force-pushed the access-pr branch from b4cd702 to 2b4f8d9 Compare April 20, 2020 03:31

blueskycs2c requested a review from t8m April 20, 2020 03:33

t8m requested changes Apr 20, 2020

View reviewed changes

blueskycs2c force-pushed the access-pr branch from 2b4f8d9 to caba011 Compare April 26, 2020 08:44

pam_access: Support UID and GID in access.conf

14b5b58

blueskycs2c force-pushed the access-pr branch from caba011 to 14b5b58 Compare April 26, 2020 08:49

ldv-alt added the enhancement label May 1, 2021

mluckam mentioned this pull request Aug 8, 2023

pam_access: Support UID and GID in access.conf #601

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pam_access: Support UID and GID in access.conf #186

pam_access: Support UID and GID in access.conf #186

blueskycs2c commented Mar 11, 2020

blueskycs2c commented Mar 17, 2020

ldv-alt commented Mar 17, 2020 via email

blueskycs2c commented Mar 17, 2020

ldv-alt commented Mar 23, 2020

blueskycs2c commented Mar 25, 2020

t8m left a comment

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

t8m Apr 15, 2020

blueskycs2c commented Apr 20, 2020

t8m left a comment

t8m Apr 20, 2020

t8m Apr 20, 2020

t8m Apr 20, 2020

t8m Apr 20, 2020

t8m Apr 20, 2020

mluckam commented May 22, 2023

t8m commented Jul 25, 2023

pam_access: Support UID and GID in access.conf #186

Are you sure you want to change the base?

pam_access: Support UID and GID in access.conf #186

Conversation

blueskycs2c commented Mar 11, 2020

blueskycs2c commented Mar 17, 2020

ldv-alt commented Mar 17, 2020 via email

blueskycs2c commented Mar 17, 2020

ldv-alt commented Mar 23, 2020

blueskycs2c commented Mar 25, 2020

t8m left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

blueskycs2c commented Apr 20, 2020

t8m left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mluckam commented May 22, 2023

t8m commented Jul 25, 2023