Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faillock: Hide unlocked users when showing locked users #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BugBaron
Copy link

The pam_tally[2] program would only show users who had failed login
attempts. The equivalent faillock program also shows users who have
no failed login attempts.

Added a new option to the faillock program which will show users without
failed login attempts. By default this option is disabled, so the
command will not show those users.

The pam_tally[2] program would only show users who had failed login
attempts. The equivalent faillock program also shows users who have
no failed login attempts.

Added a new option to the faillock program which will show users without
failed login attempts. By default this option is disabled, so the
command will not show those users.
@ldv-alt
Copy link
Member

ldv-alt commented Jan 19, 2022

Since the word unlocked implies that something was locked but is no longer locked,
I'm not sure it is the right word to describe users with zero number of tally records.

@BugBaron
Copy link
Author

Would users without failed logins be fine instead of unlocked users? Its a bit long, but its more correct.

@ldv-alt
Copy link
Member

ldv-alt commented Jan 19, 2022

A bit longer commit message is fine if it's more correct, but
there is the same issue with the name of new option --show-unlocked.

@BugBaron
Copy link
Author

Maybe --show-all-users would work, since the default functionality can be explained in the help message. Im struggling to come up with anything more succinct to use for the option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants