pam_wheel: introduce auth_self mode #609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Linux vendors use the wheel group to make users in that group authenticate with their own password as root. Ie sudo mode.
ldv-alt
requested changes
Sep 26, 2023
| else if ((str = pam_str_skip_prefix(*argv, "group=")) != NULL) | ||
| strncpy(use_group, str, group_length - 1); | ||
| else { | ||
| pam_syslog(pamh, LOG_ERR, "unknown option: %s", *argv); | ||
| } | ||
| } | ||
|
|
||
| if ((ctrl & (PAM_DENY_ARG|PAM_TRUST_ARG)) && (ctrl & PAM_AUTH_SELF)) { | ||
| pam_syslog(pamh, LOG_ERR, "can't combine 'auth_self' with 'trust' or 'deny' args %x", ctrl); |
There was a problem hiding this comment.
%#x suits best for printing hexadecimals.
| if (ctrl & PAM_DEBUG_ARG) { | ||
| pam_syslog(pamh, LOG_NOTICE, "changing authentication target to %s", fromsu); | ||
| } | ||
| if (pam_set_item(pamh, PAM_USER, fromsu) != PAM_SUCCESS) { |
There was a problem hiding this comment.
Changing PAM_USER is a big hammer, its effects go far beyond the authentication. In particular, session stack modules would use this new PAM_USER, for example, pam_loginuid would set loginuid to the caller uid instead of the target uid, pam_limits would apply limits for the caller uid instead of the target uid, and so on. In other words, I don't see how to use this new feature safely.
There was a problem hiding this comment.
ok, good point. So that means support for this kind of authentication would have to go directly into pam_unix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Linux vendors use the wheel group to make users in that group authenticate with their own password as root. Ie sudo mode.