Unify PAM return value usage #751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PAM defines a set of common return-values, like PAM_SUCCESS or PAM_AUTH_ERR, which are used internally and in public API. Commonly these return-values are stored in variables named `retval`. Unify the naming of variables such that if-and-only-if a variable is named `retval` it holds a PAM style return-value. Also use explicitly PAM_SUCESS instead of the value 0 in assignments and comparisons.
|
While I agree with using PAM_SUCCESS instead of 0, I'm not sure where the advantage of unification of retval is. It's not like it's any special term. Contrary, it's just a short version of "return value". How should anyone guarantee that future commits won't use "retval" as return value for something else again? |
|
You could play with creating a enum, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAM defines a set of common return-values, like
PAM_SUCCESSorPAM_AUTH_ERR, which are used internally and in public API. Commonly these return-values are stored in variables namedretval.Unify the naming of variables such that if-and-only-if a variable is named
retvalit holds a PAM style return-value.Also use explicitly
PAM_SUCESSinstead of the value 0 in assignments and comparisons.