fix: moveTo not invoked when position changed #88
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Decodetalkers The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Decodetalkers
force-pushed
the
master
branch
from
d995572
to
efb55bf
Compare
| onPositionChanged: function(drag) { | ||
| taskmanager.Applet.dataModel.moveTo(drag.source.itemId, visualIndex) | ||
| } | ||
|
|
There was a problem hiding this comment.
这不是在拖拽结束之前就开始移动数据里面的东西了吗？
There was a problem hiding this comment.
因为到外面就没有dorp事件了，然后enter时候就做了个move,所以就想这么处理先
There was a problem hiding this comment.
enter时候只是move了delegate model，并没有move原始的model，你自己测试过吗，因为move之后会发送信号，会导致delegate model也发生变化，不知道会不会出什么问题，如果没有出问题，其实也可以在enter的时候就直接move原始model，这里在drop的时候move就是为了避免两个model同时发生变化。
Decodetalkers
force-pushed
the
master
branch
3 times, most recently
from
9b67ae1
to
14e2bb5
Compare
Decodetalkers
force-pushed
the
master
branch
from
14e2bb5
to
c122afe
Compare
|
TAG Bot New tag: 0.0.6 |
|
TAG Bot New tag: 0.0.7 |
|
TAG Bot New tag: 0.0.8 |
|
TAG Bot New tag: 0.0.9 |
|
TAG Bot New tag: 0.0.10 |
|
TAG Bot New tag: 0.0.11 |
|
TAG Bot New tag: 0.0.12 |
|
TAG Bot New tag: 0.0.13 |
|
TAG Bot New tag: 0.0.14 |
|
TAG Bot New tag: 0.0.15 |
|
TAG Bot New tag: 0.0.16 |
|
TAG Bot New tag: 0.0.17 |
|
TAG Bot New tag: 0.0.18 |
|
TAG Bot New tag: 0.0.19 |
|
TAG Bot New tag: 0.0.20 |
|
TAG Bot New tag: 0.0.21 |
|
TAG Bot New tag: 0.0.22 |
|
TAG Bot New tag: 0.0.23 |
Issue: linuxdeepin/developer-center#7283 Log: