fix: partial incomplete text light after column editing cut or deletion #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lJxDabab The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
TAG Bot New tag: 6.0.16 |
lJxDabab
force-pushed
the
master
branch
2 times, most recently
from
6d790b9
to
1ea878e
Compare
only the last line to be text-lighted after column editing cut or deletion Log: only the last line to be text-lighted after column editing cut or deletion Bug: https://pms.uniontech.com/bug-view-241613.html
rb-union
reviewed
Feb 2, 2024
rb-union
requested changes
Feb 2, 2024
| class DeleteTextUndoCommand : public QUndoCommand | ||
| { | ||
| public: | ||
| explicit DeleteTextUndoCommand(QTextCursor textcursor, QPlainTextEdit* edit, QUndoCommand *parent = nullptr); | ||
| explicit DeleteTextUndoCommand(QList<QTextEdit::ExtraSelection> &selections, QPlainTextEdit* edit, QUndoCommand *parent = nullptr); | ||
| explicit DeleteTextUndoCommand(QTextCursor textcursor, TextEdit *tEdit, QUndoCommand *parent = nullptr); |
There was a problem hiding this comment.
重复的构造函数可以移除，TextEdit也继承自QPlainTextEdit
|
TAG Bot New tag: 6.0.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only the last line to be text-lighted after
column editing cut or deletion
Log: only the last line to be text-lighted after
column editing cut or deletion
Bug: https://pms.uniontech.com/bug-view-241613.html