Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add app SubAlign #2159

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add app SubAlign #2159

merged 1 commit into from
May 29, 2024

Conversation

Van020530
Copy link
Contributor

Implementation of the original Merlijn van Veen calculator for aligning mains with subs.

log: add app

Implementation of the original Merlijn van Veen calculator for aligning mains with subs.

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix-header.patch中添加了<cmath>头文件,但没有删除原有的<math.h>,可能导致头文件重复包含。
  • patches/0001-fix.patch中删除了SubAlign.pro中的unix:!android:规则,但没有提供替代方案来处理非Android平台。
  • 新增了BINDIRDATADIR变量,但没有在代码中看到它们的实际使用,可能是不必要的代码。
  • SubAlign.pro中,target.path被硬编码为/opt/$${TARGET}/bin,这可能不适用于所有用户,应该提供一种方式来配置或默认值。
  • 新增了icon.filesicon.path,但没有在代码中看到对应的图标文件,可能是有意为之,但如果是无意的,那么这些行可能是多余的。
  • ios平台配置中,QMAKE_IOS_DEPLOYMENT_TARGET被设置为12.0,但没有检查是否有更合适的默认值。

是否建议立即修改:

  • 应该立即删除重复的<cmath>头文件,避免潜在的编译错误或混淆。
  • 需要提供替代方案来处理非Android平台,而不是直接删除规则。
  • 如果BINDIRDATADIR是必要的,应该确保它们在代码中得到了正确的使用。如果它们是多余的,应该移除它们。
  • 应该提供一个方式来配置或默认值来解决target.path硬编码的问题。
  • 如果icon.filesicon.path是必要的,应该确保它们在代码中得到了正确的使用。如果它们是多余的,应该移除它们。
  • 应该检查是否有更合适的默认值来设置QMAKE_IOS_DEPLOYMENT_TARGET,而不是直接设置为12.0。

@kamiyadm kamiyadm merged commit a1ed421 into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants