Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add app PMP #2160

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add app PMP #2160

merged 1 commit into from
May 29, 2024

Conversation

Van020530
Copy link
Contributor

A multi-user client-server music player with advanced file tracking

log: add app

A multi-user client-server music player with advanced file tracking

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix.patch文件中,缺少了git-svn-id字段,这可能会导致在合并时出现问题。
  • CMakeLists.txt文件中新增了DESKTOP_FILE_CONTENT变量,但在后续的file(WRITE)install(PROGRAMS)命令中没有使用这个变量。
  • install(PROGRAMS ${CMAKE_BINARY_DIR}/../src/app-icon/PMPIcon.svg DESTINATION ${CMAKE_INSTALL_PREFIX}/share/icons/hicolor/scalable/apps/)命令中使用了相对路径,这可能会导致在安装时找不到正确的文件。
  • install(TARGETS PMP-Desktop-Remote DESTINATION ${CMAKE_INSTALL_PREFIX}/bin)命令中使用了PMP-Desktop-Remote目标,但在当前的CMakeLists.txt中并没有定义这个目标。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm merged commit 533bacb into linuxdeepin:master May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants