Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add app QtFlappyBird #2161

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add app QtFlappyBird #2161

merged 1 commit into from
May 29, 2024

Conversation

Van020530
Copy link
Contributor

Qt编写的 FlappyBird

log: add game

Qt编写的 FlappyBird

log: add game
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • mainwindow.cpp文件中,使用了std::命名空间,但未在代码中看到相应的使用,可能是不必要的包含。
  • mainwindow.cpp文件中,playList->addMedia(QUrl::fromLocalFile(info.absoluteFilePath()));中的info.absoluteFilePath()可能不会返回正确的路径,因为info.setFile()方法被调用来设置文件路径,而不是info.absoluteFilePath()
  • mainwindow.cpp文件中,playList_wing->addMedia(QUrl::fromLocalFile(info.absoluteFilePath()));中的info.absoluteFilePath()可能同样存在问题,因为BGM_sfx_wing_DIR没有被正确设置。
  • BGM_sfx_wing_DIR等宏在代码中没有定义,可能是在其他文件中定义的,但当前的包含顺序没有反映这种依赖关系。
  • using namespace std;mainwindow.cpp文件中可能是多余的,因为代码中没有使用std::命名空间中的任何功能。
  • 代码中没有对info.setFile()方法的返回值进行错误处理,如果文件路径无效,可能会导致程序崩溃。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 6790a8b into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants