Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add app yarr #2162

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add app yarr #2162

merged 1 commit into from
May 29, 2024

Conversation

Van020530
Copy link
Contributor

Yet Another ReveRsi game

log: add app

Yet Another ReveRsi game

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix-desktop.patch文件中,删除和插入操作的顺序可能不正确,应该先删除再插入。
  • CMakeLists.txt文件中,install命令的用法可能不正确,应该使用DESTINATION选项而不是RUNTIME
  • 新增的DESKTOP_FILE_CONTENT变量应该添加注释说明其用途。
  • 文件yarr.desktopyarr.png的命名应该遵循项目的命名约定。
  • 安装命令中使用了相对路径,这可能会导致在不同的环境或部署中出现问题,建议使用绝对路径或环境变量。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 010c735 into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants