Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add terminal-finances #2171

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add terminal-finances #2171

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 13, 2024

Personal Financial Management

Log: add software name--terminal-finances
terminal-finances

Personal Financial Management

Log: add software name--terminal-finances
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TerminalFinances.pro文件中,shortcut.pathimages.path的路径已从/usr前缀更改为$$PREFIX,这是一个好的做法,因为它允许软件包在不同的操作系统上进行自适应。
  • icons.pathconfigs.path的路径已从/etc/xdg更改为$$PREFIX/etc/xdg,这同样有助于避免路径问题。
  • trans.path的路径已从/etc/xdg更改为$$PREFIX/etc/xdg/terminalfinances,这有助于保持路径的一致性。
  • target.path的路径已从/usr/local/bin更改为$$PREFIX/bin,这有助于避免路径问题,并且使得路径与Debian包的默认安装路径保持一致。
  • Icon属性从硬编码的/usr/share/pixmaps/terminal-finances/terminal-finances.png更改为相对路径terminal-finances,这可能是为了适应不同环境下的图标路径。
  • Terminal属性从false更改为true,这可能会改变程序的运行方式,需要确认这是否是预期的行为。

是否建议立即修改:

  • 是,特别是如果Terminal属性的更改会影响程序的预期行为,那么需要立即验证并修复这个更改。
  • 对于其他路径和配置的更改,如果它们是按照项目规范和平台兼容性来调整的,那么可以接受这些更改。但是,如果这些更改没有经过充分的测试,那么应该先进行测试再合并。

@kamiyadm kamiyadm merged commit 9e0a2f0 into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants