Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add SmillaEnlarger #2175

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add SmillaEnlarger #2175

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 13, 2024

you can pick an interesting part of your photo and blow it up to poster size.

Log: add software name--SmillaEnlarger
smilla-enlarger

you can pick an interesting part of your photo and blow it up to poster size.

Log: add software name--SmillaEnlarger
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,target.path的赋值使用了$$PREFIX/bin,建议使用$$[QT_TARGET_PREFIX]/bin来确保兼容性和可移植性。
  • desktop.filesdesktop.path中的docs/前缀应该去掉,以匹配通常的桌面文件路径格式。
  • icons.files中的img/前缀也应该去掉,以匹配通常的图标文件路径格式。
  • TryExec设置为smillaenlarger,但Exec设置为smilla-enlarger,这两个可能应该保持一致,或者在文档中说明原因。
  • 文件末尾添加了+ No newline at end of file,这可能是为了满足某些版本控制系统的要求,但通常不是必要的。

是否建议立即修改:

@kamiyadm kamiyadm merged commit fc8eb2e into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants