Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add kronos #2176

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add kronos #2176

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 13, 2024

Kronos is a desktop application for logging time in Jira

Log: add software name--kronos
kronos

Kronos is a desktop application for logging time in Jira

Log: add software name--kronos
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • kronos.pro文件中,target.path的赋值逻辑被注释掉了,但没有提供替代的路径设置方法。
  • desktop.filesicons.files被添加到INSTALLS中,但没有相应的文件被修改或创建。
  • desktop.pathicons.path被设置为$$PREFIX/share/applications/$$PREFIX/share/icons/hicolor/16X16/apps/,但没有检查这些目录是否存在或是否已准备好存储这些文件。
  • Exec键的值从/opt/kronos/bin/kronos更改为kronos,这可能会导致在某些系统上找不到可执行文件。
  • Icon键的值从/opt/kronos/resources/logo.png更改为favicon,但没有提供相应的文件。

是否建议立即修改:

  • 需要确保target.path的逻辑被正确实现,或者提供替代的路径设置方法。
  • 需要确认desktop.filesicons.files中的文件是否已经准备好被安装。
  • 需要检查desktop.pathicons.path设置的目录是否存在,或者是否有权限写入。
  • 需要验证Exec键的更改是否不会导致在系统上找不到可执行文件。
  • 需要确保Icon键的更改后,favicon文件存在于项目中。

@kamiyadm kamiyadm merged commit c0b8b11 into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants