Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add cen64-qt #2177

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add cen64-qt #2177

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 14, 2024

A customizable frontend for CEN64

Log: add software name--cen64-qt
cen64-qt

A customizable frontend for CEN64

Log: add software name--cen64-qt
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • cen64-qt.pro文件中,INCLUDEPATH的赋值应该使用+=而不是=来避免覆盖原有的INCLUDEPATH变量。
  • win32:RC_FILE的定义中,路径应该使用$${PREFIX}来确保在构建过程中正确替换为prefix路径。
  • win32|macx|linux_quazip_static构建规则中,LIBS的赋值应该使用+=而不是=来避免覆盖原有的LIBS变量。
  • src/common.cppsrc/emulation/emulatorhandler.cpp文件中,#include指令的路径应该使用<QuaZip-Qt5-1.4/quazip/...>而不是<quazip5/...>,以避免潜在的命名空间冲突。
  • patches/0001-install.patch文件中,注释掉的代码应该使用# %0而不是# %-0来保持格式的一致性。

是否建议立即修改:

@kamiyadm kamiyadm merged commit 6be2a49 into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants