Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add pumpa #2180

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add pumpa #2180

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 14, 2024

Pumpa is a simple [pump.io][1] client written in C++ and Qt

Log: add software name--pumpa
pumpa

Pumpa is a simple [pump.io][1] client written in C++ and Qt

Log: add software name--pumpa
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • pumpa.desktop文件中,Exec属性从./pumpa更改为pumpa,需要确认这是否是预期的更改,以及是否有相应的文件或脚本路径更改。
  • Icon属性从./pumpa/images/pumpa.png更改为pumpa,也需要确认这是否是预期的更改,以及图标文件是否位于正确的位置。
  • pumpa.pro文件中,target.path/usr/local/bin更改为$$PREFIX/bin,这是一个好的做法,因为它允许打包的应用程序在不同的操作系统上具有不同的安装路径。
  • 添加了desktop.filesicons.files选项,这有助于确保.desktop和图标文件被正确安装。

是否建议立即修改:

  • 是,需要确认ExecIcon属性的更改是否正确,并确保应用程序的安装路径和图标文件的位置是正确的。同时,确保添加了必要的安装选项,以便在不同的操作系统上正确安装应用程序。

@kamiyadm kamiyadm merged commit 1ee079a into linuxdeepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants